From owner-freebsd-arch Wed Feb 28 20:32:29 2001 Delivered-To: freebsd-arch@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 51A2337B719 for ; Wed, 28 Feb 2001 20:32:27 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f214WNd45265; Wed, 28 Feb 2001 21:32:23 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103010432.f214WNd45265@harmony.village.org> To: mjacob@feral.com Subject: Re: lossage of a sort with using device hints... Cc: arch@FreeBSD.ORG In-reply-to: Your message of "Wed, 28 Feb 2001 10:13:08 PST." References: Date: Wed, 28 Feb 2001 21:32:23 -0700 From: Warner Losh Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message Matthew Jacob writes: : /* : * Resources from config(8). : */ : typedef enum { : RES_INT, RES_STRING, RES_LONG : } resource_type; : : : : But I've been happily using a getenv_quad for a 64 bit WWN override. : : It strikes me that RES_INT and RES_LONG are too vague (as well as useless). : How hard would it be to change these to RES_INT32 and RES_INT64? I think this is a great idea, in theory, and will take a look at changing them in the affacted places. I'll let you know how hard it turns out to be. Also, in my original "hints" implementation, numbers had to be preceeded by a # sign. I'll see what can be done to preserve values here. It might make sense to grab all numbers as 64 bit quantities with strtoll[u]. Or maybe it makes sense to just store everything as a string and have the resource_*_value function tease a meaning out of the string when called. There's not a performance hit for doing that since most values are querried only once or twice... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message