From owner-freebsd-audit Wed Feb 23 22:57:48 2000 Delivered-To: freebsd-audit@freebsd.org Received: from MailAndNews.com (MailAndNews.com [199.29.68.160]) by hub.freebsd.org (Postfix) with ESMTP id BEF3F37BB0E; Wed, 23 Feb 2000 22:57:45 -0800 (PST) (envelope-from mheffner@mailandnews.com) Received: from muriel.penguinpowered.com [208.138.199.76] (mheffner@mailandnews.com); Thu, 24 Feb 2000 01:55:57 -0500 X-WM-Posted-At: MailAndNews.com; Thu, 24 Feb 00 01:55:57 -0500 Content-Length: 1237 Message-ID: X-Mailer: XFMail 1.4.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Thu, 24 Feb 2000 01:57:19 -0500 (EST) Reply-To: Mike Heffner From: Mike Heffner To: Kris Kennaway Subject: RE: hylafax patch (fwd) Cc: audit@freebsd.org, Alexander Langer Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 21-Feb-2000 Kris Kennaway wrote: | Does someone have the time to look this over? | | Kris | | ---- | "How many roads must a man walk down, before you call him a man?" | "Eight!" | "That was a rhetorical question!" | "Oh..then, seven!" -- Homer Simpson | | ---------- Forwarded message ---------- | Date: Mon, 21 Feb 2000 15:30:19 +0100 | From: Alexander Langer | To: kris@freebsd.org | Subject: hylafax patch | | Hello! | | These should *really* fix it. | | I replaced almost all sprintf and the problematic strcpy/strcat ones. | | Could you review it and maybe add? | Well, I did a quick glance over it. It should really use sizeof() rather than hardcoding the buffer lengths, which could become changed in one location and not another. Also, should it fail if the supplied string is too long for the buffer in some places (ie. supplied command-line args) ? /**************************************** * Mike Heffner * * Fredericksburg, VA * * ICQ# 882073 * * Sent at: 24-Feb-2000 -- 01:55:57 EST * * http://my.ispchannel.com/~mheffner * ****************************************/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message