From owner-freebsd-hackers@freebsd.org Sun Jan 17 08:30:13 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4363A6AB7C for ; Sun, 17 Jan 2016 08:30:13 +0000 (UTC) (envelope-from kib@kib.kiev.ua) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4EE251628; Sun, 17 Jan 2016 08:30:12 +0000 (UTC) (envelope-from kib@kib.kiev.ua) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u0H8U7iH065533 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 17 Jan 2016 10:30:08 +0200 (EET) (envelope-from kib@kib.kiev.ua) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u0H8U7iH065533 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=kib.kiev.ua; s=tom; t=1453019411; bh=/WkNr7gjPwudnE5cgOVyx55G+y5puKFxyXKL6M4itsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oDHeMigqemwzUnVKIhsfA9qGgG6Du17br2bi0umfMhObHAaPPXXlvrJcbva3E3CVz XbzQ7L6Fk7bbBnR8PbiK7NCKqh2V1uCFuAiMJuCQv5yYLkGDdvrpYHOSCXCysWvttt xFZTYfP9PWxY7u7frJYYUfZqt1w7yjapog0/NQNA= Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u0H8U7vH065532; Sun, 17 Jan 2016 10:30:07 +0200 (EET) (envelope-from kib@kib.kiev.ua) X-Authentication-Warning: tom.home: kostik set sender to kib@kib.kiev.ua using -f Date: Sun, 17 Jan 2016 10:30:07 +0200 From: Konstantin Belousov To: Mateusz Guzik Cc: Vijay Singh , freebsd-hackers@freebsd.org, Chagin Dmitry Subject: Re: irrelevant locking Message-ID: <20160117083007.GQ3942@kib.kiev.ua> References: <20160116195819.GA41610@chd.heemeyer.club> <20160116202643.GL3942@kib.kiev.ua> <20160116224312.GA1963@dft-labs.eu> <20160117034315.GN3942@kib.kiev.ua> <20160117082439.GB1963@dft-labs.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k4f25fnPtRuIRUb3" Content-Disposition: inline In-Reply-To: <20160117082439.GB1963@dft-labs.eu> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-Mailman-Approved-At: Sun, 17 Jan 2016 12:42:44 +0000 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2016 08:30:13 -0000 --k4f25fnPtRuIRUb3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 17, 2016 at 09:24:40AM +0100, Mateusz Guzik wrote: > As a side note I think current code is buggy. VOP_CLOSE is being called > with only shared lock held even for filesystems without > MNTK_EXTENDED_SHARED, I don't know how harmful this really is. Generally LK_EXCLUSIVE for VOP_CLOSE() is only needed when closing for write. Look at the vn_close() selection of the lock mode as an example. --k4f25fnPtRuIRUb3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWm1EPAAoJEJDCuSvBvK1BYkUP/j6L/TyCEasep58e8rQfJGv/ KRnh+coSW2aui+udASebtY/DvemBG8v2M2YdYb4X/L0ejqCh1zvgrz9XKqvUp4H6 rGVE3GKNKfB2tWdFl3D0PhbAirZkaoPYdj/Jhy8rDh6MKKicNRAzaDYmej2FvpqZ ft95/ht8FCZORNUiFsyL2XnHYV4baBbQrqd0L18tTizNG/TQ3qXJziu+0YZbt/V3 krbxeHwWoeyzHeqtRYRNFeIER1WBU1guVxDHIVt3qoYe4DR6ZEEMIAk0PyPR6fEE V3QoA6sgM2G65azKqnJrn66hSz/ZF2hcTWIxOOwRveLghx5VjIMSVUhab+9soY02 YC6jNXUlQksMGgtD99pZXF3s4kPsZcPTc3SrPdCLfr+de0xIu8q73eUC3pRUvIWD BNiBqpvDbS8Pv7D/WN+YBfswLAC21aOQtP2pb8A798gpB7Q5lL2ovTmza9tarm+Y nUy5mQqu2LHASjcFSbMh/3Wtr3hD0mEKKgjMUlWNre9GTeZZF3TEglMcEi7hXjRf VQ4gEM5U85+1A5dKHZU72rH6Wjro2GiFmHgdrXxT5QyVBEGB2c231U/zbPiBcg0U z1etSYvzzkr+AEVc+pdeYBEBFs9QsklTr0N+Hhv2EVeopmDfTFhncHbZisUl79Xe nqoK56zvD3gnHqZ+63Nv =cdFW -----END PGP SIGNATURE----- --k4f25fnPtRuIRUb3--