From owner-svn-src-all@FreeBSD.ORG Mon Dec 12 21:54:34 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67389106566B; Mon, 12 Dec 2011 21:54:34 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6B57A8FC15; Mon, 12 Dec 2011 21:54:33 +0000 (UTC) Received: by faaf16 with SMTP id f16so931889faa.13 for ; Mon, 12 Dec 2011 13:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=apDSeh+feYNvE3EXA0Nx54nDnBjg48Fm8+jdAHRgGFs=; b=KiNy/s+miQ6awnBnBSkAveX4nLQ4o6E3GKze1BbtPu5fDNC/ENmD+fe2JWrEPP4xqM 7E4xsIVkHsLrIE/CTfrAAPUeh4iUIe6TQrtnAZzKKt67RWKFuqtTE0VZ6IoNs/Yzn1iQ l5vCAfJEOK/i7NPIlo9zRq/aURHMZEc1n6Snc= MIME-Version: 1.0 Received: by 10.180.74.211 with SMTP id w19mr24134021wiv.7.1323726872230; Mon, 12 Dec 2011 13:54:32 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.216.171.8 with HTTP; Mon, 12 Dec 2011 13:54:32 -0800 (PST) In-Reply-To: <4EE636BB.7050008@FreeBSD.org> References: <201112121005.pBCA5Dar093711@svn.freebsd.org> <20111212101558.GK50300@deviant.kiev.zoral.com.ua> <4EE5D574.9080303@FreeBSD.org> <4EE636BB.7050008@FreeBSD.org> Date: Mon, 12 Dec 2011 22:54:32 +0100 X-Google-Sender-Auth: 6bHrRjDNMQHlr2dI4bOVsM7MzRE Message-ID: From: Attilio Rao To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Kostik Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228433 - in head/sys: kern security/mac X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2011 21:54:34 -0000 2011/12/12 Andriy Gapon : > on 12/12/2011 19:05 Attilio Rao said the following: >> More precisely, what do you think about the patch below? >> I just didn't revert the moving of systm.h under param.h because Bruce >> seems to prefer that. >> >> I'm starting test-compile right now, let me know your preference. > > The patch looks good to me. > >> Index: sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c >> (revision 228438) >> +++ sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c =C2=A0 =C2= =A0 (working copy) >> @@ -5877,6 +5877,9 @@ dtrace_probe(dtrace_id_t id, uintptr_t arg0, uintp >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 volatile uint16_t *flags; >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 hrtime_t now; >> >> + =C2=A0 =C2=A0 =C2=A0 if (SCHEDULER_STOPPED()) >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return; >> + > > I think that this could even be "panicstr !=3D NULL", there is probably n= o use for > DTrace at panic time. I agree, I will go with panicstr. > >> =C2=A0#if defined(sun) >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* Kick out immediately if this CPU is = still being born (in which case >> Index: sys/security/mac/mac_priv.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/security/mac/mac_priv.c (revision 228438) >> +++ sys/security/mac/mac_priv.c (working copy) >> @@ -42,7 +42,6 @@ __FBSDID("$FreeBSD$"); >> =C2=A0#include "opt_mac.h" >> >> =C2=A0#include >> -#include >> =C2=A0#include >> =C2=A0#include >> =C2=A0#include > > I would even keep this inclusion, just for the "why not" reason. If it passes testing I will remove it as it is unneeded. Attilio --=20 Peace can only be achieved by understanding - A. Einstein