From owner-svn-src-all@FreeBSD.ORG Tue Dec 27 19:41:31 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id B20291065672; Tue, 27 Dec 2011 19:41:31 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 5EAAF14DDA1; Tue, 27 Dec 2011 19:41:31 +0000 (UTC) Message-ID: <4EFA1F6B.6050101@FreeBSD.org> Date: Tue, 27 Dec 2011 11:41:31 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Marius Strobl References: <201112241216.pBOCGd1H012696@svn.freebsd.org> <4EF645D2.8080407@FreeBSD.org> <20111226102820.GT90831@alchemy.franken.de> <4EF8DC5B.9070404@FreeBSD.org> <20111227162757.GW90831@alchemy.franken.de> In-Reply-To: <20111227162757.GW90831@alchemy.franken.de> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r228857 - in head/usr.bin: . csup X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2011 19:41:31 -0000 On 12/27/2011 08:27, Marius Strobl wrote: > On Mon, Dec 26, 2011 at 12:43:07PM -0800, Doug Barton wrote: >> On 12/26/2011 02:28, Marius Strobl wrote: >>> On Sat, Dec 24, 2011 at 01:36:18PM -0800, Doug Barton wrote: >>>> On 12/24/2011 04:16, Marius Strobl wrote: >>>>> On FreeBSD just use the MD5 implementation of libmd rather than that of >>>>> libcrypto so we don't need to relinquish csup when world is built without >>>>> OpenSSL. >>>> >>>> Did you benchmark this at all? I agree that keeping csup available >>>> absent openssl is a good goal, but csup is a prototypical "tool that >>>> does the same thing many thousands of times" so even tiny regressions >>>> could add up to a large cost in wall clock time. >>> >>> Well, in a real world test updating the same base on an amd64 machine >>> connected to the Internet >> >> Adding a network connection to the test is almost certainly going to >> obscure the results beyond utility. The appropriate way to test this >> would be to create a binary out of the md5 routine in csup, and link it >> alternately with libcrypto and libmd. Then for each version run it >> against the src tree (or ports, either way) 10 times. Discard the first >> and last, and then plot the results with ministat. > > marius@flak:/home/marius > ministat -w 76 libmd libcrypto > x libmd > + libcrypto > +----------------------------------------------------------------------------+ > | + | > | + | > |x x + | > |xxx ++ | > |xxx ++ +| > ||A| |A_| | > +----------------------------------------------------------------------------+ > N Min Max Median Avg Stddev > x 8 244.08 246.16 245.18 245.01375 0.78758106 > + 8 302.36 307.12 302.92 303.26875 1.5784028 > Difference at 95.0% confidence > 58.255 +/- 1.33776 > 23.7762% +/- 0.545992% > (Student's t, pooled s = 1.24732) > > Looks like the MD5 implementation of libcrypto is the counterpart of > SCHED_ULE and only pays out on real big stuff. At least this result > is consistent with the real world test of csup. That's awesome news! Thanks for doing this additional work, and I'm glad to see that the result is a win-win. :) Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/