From owner-svn-ports-head@freebsd.org Thu Mar 14 16:19:24 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3031D15489AA for ; Thu, 14 Mar 2019 16:19:24 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB7B4871AE; Thu, 14 Mar 2019 16:19:23 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 9E8433819; Thu, 14 Mar 2019 16:19:23 +0000 (UTC) Date: Thu, 14 Mar 2019 16:19:23 +0000 From: Alexey Dokuchaev To: Kurt Jaeger Cc: ports-committers@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495383 - in head/java: . wildfly16 wildfly16/files Message-ID: <20190314161923.GA5046@FreeBSD.org> References: <201903111943.x2BJhchV074502@repo.freebsd.org> <20190312021938.GA4479@FreeBSD.org> <20190313171719.GS88817@fc.opsec.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190313171719.GS88817@fc.opsec.eu> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: CB7B4871AE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 16:19:24 -0000 On Wed, Mar 13, 2019 at 06:17:19PM +0100, Kurt Jaeger wrote: > > > Log: > > > New port: java/wildfly16 > [...] > > Its name suggests it should've been repocopied from one of the earlier > > versions but it was not, why is that? > > I missed it, that is common for arkane rules. There's nothing arcane about repocopies Kurt. I'm honestly surprised why people make this mistake again and again. When you resurrect a port you make a repocopy. When you spin-off a new branch based on a previous version you make a repocopy (like you've added a new wildfly port, how could you not have noticed that there are a handful of ports thereof already?): $ grep wildfly /usr/ports/java/Makefile SUBDIR += wildfly10 SUBDIR += wildfly11 SUBDIR += wildfly12 SUBDIR += wildfly13 SUBDIR += wildfly14 SUBDIR += wildfly15 SUBDIR += wildfly90 Upstream renames their software, you make a repocopy, etc. Basically, every time there is an ancestral connection between what you've about to add and some [pre-]existing port, you make a repocopy. It's a no brainer. Feel free to ask me every time when you have your doubts. ./danfe