Date: Fri, 20 May 2016 11:00:22 -0400 From: Allan Jude <allanjude@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300257 - in head/sys/boot/i386: libi386 zfsboot Message-ID: <573F2686.20509@freebsd.org> In-Reply-To: <1780135.VYYOsNudFi@ralph.baldwin.cx> References: <201605200141.u4K1flpV094958@repo.freebsd.org> <1780135.VYYOsNudFi@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-05-20 10:48, John Baldwin wrote: > On Friday, May 20, 2016 01:41:47 AM Allan Jude wrote: >> Author: allanjude >> Date: Fri May 20 01:41:47 2016 >> New Revision: 300257 >> URL: https://svnweb.freebsd.org/changeset/base/300257 >> >> Log: >> Fixup the geliboot sector rounding code >> >> Replace all rounding with the round{up,down}2 macros >> a missing set of braces caused the previous code to be incorrect >> >> replace alloca() with malloc() because alloca() can return an allocation >> that is actually invalid, causing boot to fail > > No, you have to revert the malloc! malloc() can be anywhere. The alloca > is _on purpose_ to get a bufer below 1MB so that it will work with all > devices. Some BIOSes can only store data in the first 1MB. > to be clear, the alloca() was something I added, not something that was there before. And it was breaking, because ZFS was trying to allocate too large a block of memory, that wouldn't fit below 1MB. -- Allan Jude
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?573F2686.20509>