From owner-cvs-src@FreeBSD.ORG Thu Oct 2 16:10:53 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9AE1410656A0; Thu, 2 Oct 2008 16:10:53 +0000 (UTC) (envelope-from jhay@meraka.csir.co.za) Received: from zibbi.meraka.csir.co.za (zibbi.meraka.csir.co.za [IPv6:2001:4200:7000:2::1]) by mx1.freebsd.org (Postfix) with ESMTP id D726B8FC08; Thu, 2 Oct 2008 16:10:52 +0000 (UTC) (envelope-from jhay@meraka.csir.co.za) Received: by zibbi.meraka.csir.co.za (Postfix, from userid 3973) id A84F333CD6; Thu, 2 Oct 2008 18:10:46 +0200 (SAST) Date: Thu, 2 Oct 2008 18:10:46 +0200 From: John Hay To: Ed Schouten Message-ID: <20081002161046.GA5678@zibbi.meraka.csir.co.za> References: <200809291627.m8TGRaat081340@repoman.freebsd.org> <20081002122511.GW16837@hoeg.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081002122511.GW16837@hoeg.nl> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, Sam Leffler , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2008 16:10:53 -0000 On Thu, Oct 02, 2008 at 02:25:11PM +0200, Ed Schouten wrote: > Hello Sam, > > * Sam Leffler wrote: > > sam 2008-09-29 16:27:32 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/ifconfig ifconfig.c > > Log: > > SVN rev 183466 on 2008-09-29 16:27:32Z by sam > > > > Distinguish between cmd/parameters used for clone operations and > > all others. Use this to disambiguate cmd line arguments that can > > be either clone params or regular parameters so, in particular, > > "bssid" again works as a regular parameter. > > > > While here leverage the above to improve the logic for flushing > > clone operations on the first !clone cmd line parameter. > > > > Reviewed by: jhay > > Is it possible that this commit broke `ifconfig foo vlan bar vlandev baz'? > I just had to revert to an ifconfig, probably from September 22, to make > my system work properly again. And if you try with "ifconfig foo create vlan bar vlandev baz"? I have only tried it with the create keyword added and the clone stuff in /etc/network.subr also use it like that, if I read the code correctly. I think if it previously worked, it was by accident. :-/ If we need it to work, maybe one can test for vlan in main() whith the test for create or plumb? John -- John Hay -- John.Hay@meraka.csir.co.za / jhay@FreeBSD.org