From owner-freebsd-fs@FreeBSD.ORG  Fri Jun 11 16:12:08 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 30CCA106564A
	for <freebsd-fs@freebsd.org>; Fri, 11 Jun 2010 16:12:08 +0000 (UTC)
	(envelope-from ivoras@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F1B78FC0C
	for <freebsd-fs@freebsd.org>; Fri, 11 Jun 2010 16:12:06 +0000 (UTC)
Received: by fg-out-1718.google.com with SMTP id d23so246201fga.13
	for <freebsd-fs@freebsd.org>; Fri, 11 Jun 2010 09:12:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:mime-version:sender:received
	:in-reply-to:references:from:date:x-google-sender-auth:message-id
	:subject:to:cc:content-type;
	bh=f1RokaG63qog1hhpCLdXgKCdteQnUmKa38pqTmn1z28=;
	b=Zf2r3UiQ+ntNOh+NFD3keVzb44FSoMMAP8bcnryyCpMUxla8kQtBnm/AVYl5P5sQ5W
	RIKCwqbqyrwWLf7VOOfe6ILWcGWnhPtZktGakTNG2nD7e7FXBpLXVYiQHdsu3ASTp6g0
	0AL40UIbHVyzqwo6Ejd6vkX7dZ66b5KPCeNnc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	b=Z3Y+ScGOsOVTzOp7Wmt1a+h4iRCaRPAZilUjrvK7Fb1o9ukpWf0h0PUiuCnMGGQlsV
	Qys4CqR4O/9BM+rMWS8IeG2h0tHuTrmk6S6uxWXd3Cg1ZdnK6b/Xs44veAUG1c0bOe1i
	TUG7xAJf4XTabADz15ZgKsw5F8iPh4KalzLWw=
Received: by 10.216.179.138 with SMTP id h10mr1179376wem.49.1276272725571; 
	Fri, 11 Jun 2010 09:12:05 -0700 (PDT)
MIME-Version: 1.0
Sender: ivoras@gmail.com
Received: by 10.216.89.197 with HTTP; Fri, 11 Jun 2010 09:11:45 -0700 (PDT)
In-Reply-To: <20100611172033.42001s90ahe57oe8@webmail.leidinger.net>
References: <20100610162629.38992mazf0sfdqg0@webmail.leidinger.net> 
	<hut8o7$q2o$1@dough.gmane.org>
	<20100611172033.42001s90ahe57oe8@webmail.leidinger.net>
From: Ivan Voras <ivoras@freebsd.org>
Date: Fri, 11 Jun 2010 18:11:45 +0200
X-Google-Sender-Auth: cBtPpfA_UZZbY1XRQP_1Mch67qI
Message-ID: <AANLkTilBqAsDnDs4nlsVjBdt1U9554t9rNuzMruqRJqE@mail.gmail.com>
To: Alexander Leidinger <Alexander@leidinger.net>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-fs@freebsd.org
Subject: Re: CFT: periodic scrubbing of ZFS pools
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2010 16:12:08 -0000

On 11 June 2010 17:20, Alexander Leidinger <Alexander@leidinger.net> wrote:
> Quoting Ivan Voras <ivoras@freebsd.org> (from Fri, 11 Jun 2010 14:04:24
> +0200):

>> Fairly good and useful, but could you add a small check of "zpool
>> status" information before scrubbing that would a) complain LOUDLY AND
>> VISIBLY if a previous scrub failed and b) skip issuing a new scrub
>> command if there is such an error, to avoid stressing possibly broken
>> hardware?
>
> Can you please provide an example of such a failed scrub?

You should probably treat any status message that doesn't have "none
requested" or "scrub completed with 0 errors..." as failed.

I could setup a gnop device with errors to prove it if you'd like :)