Date: Thu, 22 Dec 2016 10:13:44 +0000 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com> To: Colin Percival <cperciva@tarsnap.com> Cc: FreeBSD Lists <freebsd-xen@freebsd.org>, John Baldwin <jhb@FreeBSD.org> Subject: Re: svn commit: r310177 - in head/sys: amd64/conf i386/conf Message-ID: <20161222101344.swlw37j2of7iiwm5@dhcp-3-221.uk.xensource.com> In-Reply-To: <0100015923b8e2f4-689d4cb8-61d4-4634-8165-5a2c7bf537dd-000000@email.amazonses.com> References: <201612162110.uBGLAbG3091898@repo.freebsd.org> <0100015923b8e2f4-689d4cb8-61d4-4634-8165-5a2c7bf537dd-000000@email.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 21, 2016 at 11:30:36PM +0000, Colin Percival wrote: > This commit breaks the Xen boot: > > panic: NULL pcpu device_t > > > cpuid = 0 > > > KDB: stack backtrace: > > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffffff82233a20 > > > vpanic() at vpanic+0x186/frame 0xffffffff82233aa0 > > > kassert_panic() at kassert_panic+0x126/frame 0xffffffff82233b10 > > > xen_setup_cpus() at xen_setup_cpus+0x5b/frame 0xffffffff82233b50 > > > mi_startup() at mi_startup+0x118/frame 0xffffffff82233b70 > > > btext() at btext+0x2c > > > I'm assuming this means xenpvcpu_attach isn't running early enough; does > anyone have time to track this down and fix it? xen_intr_alloc_and_bind_ipi requires a non-NULL device_t, and with the changes to the AP startup code now xen_cpu_ipi_init gets called before the dummy pcpu devices are attached. I will try to find some time this afternoon/tomorrow in order to rework the ipi bind function so that it no longer requires a device_t (it seems kind of pointless anyway, since IPIs by definition always belong to the CPU package). Roger.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161222101344.swlw37j2of7iiwm5>