From owner-freebsd-chromium@FreeBSD.ORG Sun Feb 6 23:59:06 2011 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56E3E106564A for ; Sun, 6 Feb 2011 23:59:06 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 20D058FC0A for ; Sun, 6 Feb 2011 23:59:05 +0000 (UTC) Received: by iwn39 with SMTP id 39so4095953iwn.13 for ; Sun, 06 Feb 2011 15:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:date:x-google-sender-auth :message-id:subject:from:to:content-type; bh=0oV8ZHAnsFIHj/xVCklm/SO6UvUoz6nG4FXpN+ZhvUE=; b=JoX03FepokrAkiCPCDaaz0rNooy4q/4UCMb21LxWLB4g2aJl+QDE27BeeEE+oPcFib BERJ+YmgxxYWN/CbYgXgto2Dw0OcHwuTo68LqdKAjJESEVbZSVcI0tibo3rAO7cOpWHc XuRxIyPzNyQIHlKmNxfnrzjtb31PFOCyZx5XU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=lfDagk/MoHJKzKONWPJGsvpHKgzZG5qFNHH/NESl+PVaPh2N91CxeG40cOE7DlT7vJ T5rbdsSu3HdffShYnHc+NyoGKgunPnmVyXYoBQc5Tyv8QND0pAmeuDmu5up10ZxPG7IJ NivRf+PyXqyHnlbWhXDF/YoShvNVSo9QMYj0I= MIME-Version: 1.0 Received: by 10.231.182.5 with SMTP id ca5mr3993448ibb.144.1297036744810; Sun, 06 Feb 2011 15:59:04 -0800 (PST) Sender: baptiste.daroussin@gmail.com Received: by 10.231.182.132 with HTTP; Sun, 6 Feb 2011 15:59:04 -0800 (PST) Date: Sun, 6 Feb 2011 23:59:04 +0000 X-Google-Sender-Auth: OKkLThU5nCVkDrUBl36Jko9oiGM Message-ID: From: Baptiste Daroussin To: freebsd-chromium@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: [PATCH] clean process task management :) X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2011 23:59:06 -0000 Hi, with the following patches chromium should be /proc free or very close to. I replaced the base/process_util_linux.cc by a base/process_util_freebsd.cc which have some code copied/inspired from process_util_mac.mm and some code from me (most of it :)) I also comes with a fix : moving GetNumberOfProcessor() from sys_info_proc to sys_info_freebsd as it is done for openbsd. in process_util_freebsd is only miss the EnableTerminasonOnOutOfMemory (because I can't understand anything on that :)) so I disabled it from chrome/app/chome_exe_main_gtk.cc (should be fixed, but I don't know how :) any volunteer ?) from my point of view the taskmanager work, I wan't test about:memory as I am still not able to render a page. May be there are some mistakes in unit (kByte instead of Byte or things like that I can't check) the way we list processes (the same that is done on mac) is way cleaner than the linux one, and should perform better. You can find the patches here: http://people.freebsd.org/~bapt/chrome-noproc/ some are new some just replace the exiting one. after that you need to edit base/base.gpyi to exclue process_util_linux.cc on freebsd and append process_util_freebsd.cc to the long list of cc files (sorry I haven't made a patch for that. Now time to sleep :) regards, Bapt