Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Sep 2015 07:51:34 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Ryan Steinmetz <zi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r397981 - head/net-mgmt/net-snmp
Message-ID:  <5606B0F6.1060101@FreeBSD.org>
In-Reply-To: <5606B0A6.8040402@FreeBSD.org>
References:  <201509261421.t8QELert003508@repo.freebsd.org> <5606B0A6.8040402@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--uGbH6eq5e5HLUDsCJsjGWcTrFP01fkunW
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 9/26/2015 7:50 AM, Bryan Drewery wrote:
> On 9/26/2015 7:21 AM, Ryan Steinmetz wrote:
>> Author: zi
>> Date: Sat Sep 26 14:21:39 2015
>> New Revision: 397981
>> URL: https://svnweb.freebsd.org/changeset/ports/397981
>>
>> Log:
>>   - Honor WITHOUT_SSP
>>  =20
>>   PR:		203369
>>   Submitted by:	Kenneth Salerno <kennethsalerno@yahoo.com>
>>
>> Modified:
>>   head/net-mgmt/net-snmp/Makefile
>>
>> Modified: head/net-mgmt/net-snmp/Makefile
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/net-mgmt/net-snmp/Makefile	Sat Sep 26 14:13:44 2015	(r397980)=

>> +++ head/net-mgmt/net-snmp/Makefile	Sat Sep 26 14:21:39 2015	(r397981)=

>> @@ -52,10 +52,13 @@ CONFIGURE_ARGS+=3D--enable-shared --enable
>>  		--with-logfile=3D"${NET_SNMP_LOGFILE}" \
>>  		--with-persistent-directory=3D"${NET_SNMP_PERSISTENTDIR}" \
>>  		--with-gnu-ld --with-libwrap \
>> -		--with-libs=3D"-lssp_nonshared" \
>>  		--with-ldflags=3D"-lm -lkvm -ldevstat -L${PKG_PREFIX}/lib -L${LOCAL=
BASE}/lib ${LCRYPTO}"

Or just add ${LDFLAGS} in there with the other libs!

>>  SUB_FILES=3D	pkg-message
>> =20
>> +.if !defined(WITHOUT_SSP)
>> +CONFIGURE_ARGS+=3D--with-libs=3D"-lssp_nonshared"
>> +.endif
>> +
>>  .if defined(BATCH)
>>  CONFIGURE_ARGS+=3D--with-defaults
>>  .endif
>>
>=20
> bsd.ssp.mk should be in charge of this.
>=20
> I think to fix your problem you should just do:
>=20
> CONFIGURE_ARGS+=3D --with-libs=3D"${LDFLAGS:M-l*}"
>=20
> Note that there are no SSP checks here. It simple converts any -l in
> LDFLAGS to the --with-libs format. I haven't tested this yet but wanted=

> to get it out there still. Having no -l in LDFLAGS
> will pass --with-libs=3D with no params. If it builds fine like that th=
en
> it is fine. Otherwise it will be more tricky due to the ordering of
> including files from Mk/.
>=20
>=20


--=20
Regards,
Bryan Drewery


--uGbH6eq5e5HLUDsCJsjGWcTrFP01fkunW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWBrD2AAoJEDXXcbtuRpfPnpUIALksMAhAluB4wiJ8UJu7Qq/T
otSV468MaAnixmnUnhx8c8iXiuL30OvqEjwHuJ4P4x1Z6IYJHHXNOTf2O9obo6so
AKUyYL0LP1hPw/JQy5akFtxZ6HNzZpdQwTdQQ66J8/vuc7ghP+UsgB8blW4pMH/p
tr4e4N/XDxaWIkbCWmeqT/tiA/2WP+LYmrRmZ18ZmAy2WYKuUleX/ewEZzlm08bi
8oNIrBL61pBCCE39JqFt5sjyncUkDbA6SCGw2uzyw38IuEQFUss9AyPT78SMofZ8
8YlbKkdLueB4WFg22mYWqVxj8tWEjH0ELT/SWLY0DKmwpm145xdxlmUjFiI3viM=
=X5Mk
-----END PGP SIGNATURE-----

--uGbH6eq5e5HLUDsCJsjGWcTrFP01fkunW--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5606B0F6.1060101>