From owner-freebsd-current@freebsd.org Wed Jun 19 16:49:29 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C429F15BEAC5 for ; Wed, 19 Jun 2019 16:49:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8DD946E541 for ; Wed, 19 Jun 2019 16:49:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x742.google.com with SMTP id a27so11342727qkk.5 for ; Wed, 19 Jun 2019 09:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JCRMmMl5UhbYG/BpAMmQ7oAbTKUO/yRPXP8+RwfarJ4=; b=P2+Un9apkhc6VtwQtOtSNE2FA/pHjcFDhcWUyocLAdDLu6uj6vBPXxtT0t4SV+zDaN XJryINElxVUDCVrv6F2cBWPSA06Qb5TEDyvQ6SgLp8yFc+0qLhgQjBnfBAeEWGXb0nPF Mpa6YWKWDCWB4G9JewCYi9AbIZ+x5AGnSW4X277Fcuju6dXAMNFLSE9Ohhn12CaFTpKF /fHBoT5eTFZrXr5HAuiCLO+ePJ0Rxa6r38opziOGjej3fV1LDAUJbMc9Wpf/VyYd8MY8 7Osf6wLlP6yHb2VWxjVO3FE/kpr+YAYUNNZelDeg+G2fBNXg5K98t08nx0OxJ9UAa60Q Z7Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JCRMmMl5UhbYG/BpAMmQ7oAbTKUO/yRPXP8+RwfarJ4=; b=UocjTcie6RZqVOBHMPQxg0rqz7PViI4Vyvo8C2kL4Yif44KEo1kGTq4jby/nBMdJGJ kjlg1GR3sXDOHD/65kTMQ1abI12fa1TMLnDSY9qObfaeQ5X5TUkuaoa4S0QwN5pQ9eX1 nqq2KC3kSosfg0qI5fuqtEMzuisRSd+oKy5/vp07Fdk/76lXvt1fHCHkbEA9U2GV9wx0 947Ss33IpW8AmcpHq1xBX0sBfYV/17YBN5BV+HDruMH9ICcufaVAw5vACsdHM2+q9Bm+ 2d1lyL66vSEkrZHi21lrnvdTwe++8clvYBgtOJKXEj0kF7aoNNlNHRo4162GU8I1fvCb NK8w== X-Gm-Message-State: APjAAAV029VSa8amJM8P4QndU4Us4UIYb91HJiYOPsn6/wkSy/wfhvXN lEgzktQqQS6QdJi1GqtfBrcxPIhy6pFo9KJ7bdlG5w== X-Google-Smtp-Source: APXvYqzHJRxEHpO4g2p4n+7B1IhbXs6Bn4pprjgFHELD7A9hVIIjAowrvjHAQKrztv8qoLRkOiZ/Udy7fzXCZ0gXT5I= X-Received: by 2002:a37:b843:: with SMTP id i64mr7597550qkf.77.1560962967482; Wed, 19 Jun 2019 09:49:27 -0700 (PDT) MIME-Version: 1.0 References: <201906181423.x5IENGDv004245@slippy.cwsent.com> <201906191630.x5JGUJ3H018954@gndrsh.dnsmgr.net> In-Reply-To: <201906191630.x5JGUJ3H018954@gndrsh.dnsmgr.net> From: Warner Losh Date: Wed, 19 Jun 2019 09:49:16 -0700 Message-ID: Subject: Re: error: yacc.h: No such file or directory To: "Rodney W. Grimes" Cc: Cy Schubert , Ian Lepore , Enji Cooper , FreeBSD Current , Michael Tuexen , "koobs@freebsd.org" , Bryan Drewery X-Rspamd-Queue-Id: 8DD946E541 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=P2+Un9ap X-Spamd-Result: default: False [-3.43 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.919,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[ALT1.aspmx.l.google.com,aspmx.l.google.com,ALT2.aspmx.l.google.com]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_IN_DNSWL_NONE(0.00)[2.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-0.51)[ip: (2.94), ipnet: 2607:f8b0::/32(-3.13), asn: 15169(-2.30), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2019 16:49:30 -0000 On Wed, Jun 19, 2019 at 9:31 AM Rodney W. Grimes < freebsd-rwg@gndrsh.dnsmgr.net> wrote: > > In message > > , Ian Le > > pore writes: > > > On Tue, 2019-06-18 at 07:01 -0700, Enji Cooper wrote: > > > > > On Jun 18, 2019, at 06:59, Enji Cooper > > > > > wrote: > > > > > > > > > > > > > > > > On Jun 18, 2019, at 06:53, Ian Lepore wrote: > > > > > > > > > > ... > > > > > > > > > > > Last Saturday, Bryan (cc'd) made a series of commits > (r349061-69) > > > > > > that > > > > > > were all somehow related to dependency processing in the > > > > > > build. I > > > > > > don't know the details, just remember seeing some commits about > > > > > > that. > > > > > > > > > > I remember that as well. This might have changed the dependency > > > > > order subtly, introducing a race. > > > > > > > > > > The headers might not be built in all cases in time now. > > > > > > > > > > Thanks, > > > > > -Enji > > > > > > > > > > PS This is one of the reasons why I wasn???t quick to discount > Peter > > > > > Jeremy???s reported build issue. > > > > > > > > Correction: I meant Julian Stacey. > > > > > > Julian Stacey has 3 problems: > > > > > > 1. Missing opt_cam.h > > > 2. Missing yacc.h > > > 3. A years-long inability to report a problem without hurling personal > > > insults at the project and everyone associated with it. > > > > > > Because of #3, I don't much care about 1 and 2. > > > > Bingo! My point exactly! > > You can't understand the frustration of 25 years of > having system build breakage on a pretty regular basis > as a trigger point for anger? > If there really were 25 years of constant build breakages, then maybe. But this overstates the number of times it happens. In the past 10 years the number of tree breakages is 10x or more fewer than in the early days of the project when it was all the time. In the interim, we've grown a bunch of new ways to build, and the combinatorics make it impossible to exhaustively test. No matter what we do, things will break, despite people's best efforts. Getting table flipping mad is an over-reaction and frankly not actionable. If you look at the breakage lately, in general it's been in weird edge cases that not too many people do on a regular basis. Missing opt_cam.h was only for the not-with-the-kernel build path. It's supposed to work, but it breaks more often than other paths because it's significantly less used. This specific issue was actually fixed before Julian complained as well, so we caught it fairly quickly (I fixed it 5 days after it went in). We should take this as a signal that this feature isn't used much used, not as an opportunity to vent one's spleen. It's not even in the CI path today. Had it been, we'd have caught it faster. We hit this from time to time, so having it be in CI likely makes some sense. The yacc.h was an unforeseen side effect of improvements in other dependency parsing that sped up the build. And it was only for the non -j X / -B case. Since clang takes forever to build, nobody builds w/o -j #, so it went unnoticed for a few days. Since it takes a fairly beefy machine to build FreeBSD, this is an understandable oops. This one I'm not sure we should put into CI very often since it's a tricky bug to catch and it's quite rare that we have ordering issues that get tripped up by -j vs no -j. There's only so many CI resources, and given the problems in the area, I think it's a poor ROI. Warner