From nobody Fri Apr 24 00:54:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1vc56HGMz6bWM6 for ; Fri, 24 Apr 2026 00:54:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1vc53xwQz3PQS for ; Fri, 24 Apr 2026 00:54:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776992053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=53ToDbkNrVl1/fK0rNXY5PCRHNnTptLm2zHrOE0skXk=; b=mnAy7GGRYGfo9gqJWSBzMtKmGTF+CJqDuLFiesXj/mZmnNRUlRZ2YKl9ODjj/pKbG6zlR7 UQ7nCjU4iNTV2NT06+bKFdDa8PP/xgmcCxfrGpDScGX6wV6nIBeNCQMZOe9EHnvt3ty5Bp kcvQNRj/1rYtro6ct+3WodSffcrYr7g7ivguWV1GAGuAQ2sYGJW9L6oZU3HDg6LvFmbNXV 6ThHa2TVtnpZybmPrCv6RtjA0QE8NpnE/khiE/F0KZFSExd5sElkCCZD/96hemDsd9U3kE GP3PCvUKQG8T4GH2zvAhW9W+OCPJPHCM3Ks2cRs03oVW2xx/v4zDtfLl6pGOkQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776992053; a=rsa-sha256; cv=none; b=NB8OGV78uyc7KjMldLkJ6V4z1nIAVw4DgSOgxHtmnqXK1dWLygckgkaT2hgdx6ASgIgcHY 2m9vOH7ACIZsnODEuwhLW+uhreYmM/V2dlxc3J49D2pZJE856f1RyVPzDt86VFb3KOmF42 iGTxhtRuRSw1HPJEe+XzIW3iFJomkffMea436KEzcunMCr9rIWTjfJAFT8HIyC0SwLrjS6 SDVpEasXzfGbdwKALiZD25p4fZaCBFh5TUJjETpGlORSyGKxlYBytx3GsbTJtSJZyJqSKx Jwec5BluPdwnQ/tWSuehpFSS0Sj9APmBy6rPhD0L9kSrWQWdVBa7X7wIgDQmlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776992053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=53ToDbkNrVl1/fK0rNXY5PCRHNnTptLm2zHrOE0skXk=; b=ZoPskxA3xp1MMSh6oQ+iPuyaYW2PC9/DYLAgqifjRD4YA3Aqt9E9T1M8yqBhtlsWMvAV63 SnXm/FIVa1NJIFk8QkLZJyV7Rnffw2E3vfPpG9cxWcNaS2IauOc4DtO/yzJVVKv8dtpMd4 QjopcuaxC6eu1S4j4jL50TpXmVSs5RDFD3qnDxOtgmKwiAmaijoprkiMKXKnzb7qIVK5WS pThbhChfVVRcgQpnCiVDvCFXKdq7xNy31ndp1IC8D1TgRpsCZDM37Q1lOaMy8krp+QUZKH P2tD/FBcGL0IuqUpMeaGhchM9pGq4trdp0X7V9hx/WEAPRJlbcCAerhypvBxxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g1vc52kwZzh2q for ; Fri, 24 Apr 2026 00:54:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21b1e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 00:54:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Christos Longros From: Jose Luis Duran Subject: git: 5fd7eb1b8996 - stable/15 - ping6: treat setsockopt failures as fatal List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 5fd7eb1b89962c16ed7f2c551790dfded6534659 Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 00:54:13 +0000 Message-Id: <69eabf35.21b1e.f2c36e9@gitrepo.freebsd.org> The branch stable/15 has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=5fd7eb1b89962c16ed7f2c551790dfded6534659 commit 5fd7eb1b89962c16ed7f2c551790dfded6534659 Author: Christos Longros AuthorDate: 2026-04-17 18:19:24 +0000 Commit: Jose Luis Duran CommitDate: 2026-04-24 00:51:05 +0000 ping6: treat setsockopt failures as fatal ping6 needs IPV6_RECVPKTINFO and IPV6_RECVHOPLIMIT to process incoming replies. When these options fail, replies are silently dropped and ping6 appears to hang. Use err(3) instead of warn(3) so the user gets a clear error and immediate exit. Signed-off-by: Christos Longros Reviewed by: pouria, jlduran, glebius MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D56237 (cherry picked from commit 9a4a9f623bbaf991b3ba580593d47f2ee9f7b03b) --- sbin/ping/ping6.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/ping/ping6.c b/sbin/ping/ping6.c index 356f0f72a6f8..f81de062e59a 100644 --- a/sbin/ping/ping6.c +++ b/sbin/ping/ping6.c @@ -1083,21 +1083,21 @@ ping6(int argc, char *argv[]) #ifdef IPV6_RECVPKTINFO if (setsockopt(srecv, IPPROTO_IPV6, IPV6_RECVPKTINFO, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_RECVPKTINFO)"); /* XXX err? */ + err(1, "setsockopt(IPV6_RECVPKTINFO)"); #else /* old adv. API */ if (setsockopt(srecv, IPPROTO_IPV6, IPV6_PKTINFO, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_PKTINFO)"); /* XXX err? */ + err(1, "setsockopt(IPV6_PKTINFO)"); #endif #endif /* USE_SIN6_SCOPE_ID */ #ifdef IPV6_RECVHOPLIMIT if (setsockopt(srecv, IPPROTO_IPV6, IPV6_RECVHOPLIMIT, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_RECVHOPLIMIT)"); /* XXX err? */ + err(1, "setsockopt(IPV6_RECVHOPLIMIT)"); #else /* old adv. API */ if (setsockopt(srecv, IPPROTO_IPV6, IPV6_HOPLIMIT, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_HOPLIMIT)"); /* XXX err? */ + err(1, "setsockopt(IPV6_HOPLIMIT)"); #endif cap_rights_clear(&rights_srecv, CAP_SETSOCKOPT);