From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 19 14:20:23 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB11616A4CE for ; Mon, 19 Jan 2004 14:20:23 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CE8C43D5A for ; Mon, 19 Jan 2004 14:20:09 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0JMK9FR095594 for ; Mon, 19 Jan 2004 14:20:09 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0JMK8Jr095593; Mon, 19 Jan 2004 14:20:08 -0800 (PST) (envelope-from gnats) Resent-Date: Mon, 19 Jan 2004 14:20:08 -0800 (PST) Resent-Message-Id: <200401192220.i0JMK8Jr095593@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrew Thompson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39CC416A4CE; Mon, 19 Jan 2004 14:19:47 -0800 (PST) Received: from smtp.fud.org.nz (203-79-110-29.cable.paradise.net.nz [203.79.110.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1959443D2D; Mon, 19 Jan 2004 14:19:43 -0800 (PST) (envelope-from andy@fud.org.nz) Received: by smtp.fud.org.nz (Postfix, from userid 1001) id D2410170A9; Tue, 20 Jan 2004 11:19:40 +1300 (NZDT) Message-Id: <20040119221940.D2410170A9@smtp.fud.org.nz> Date: Tue, 20 Jan 2004 11:19:40 +1300 (NZDT) From: Andrew Thompson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: njl@FreeBSD.org Subject: kern/61592: [PATCH] Reverse logic for user override in acpi_thermal.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Andrew Thompson List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2004 22:20:23 -0000 >Number: 61592 >Category: kern >Synopsis: [PATCH] Reverse logic for user override in acpi_thermal.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 19 14:20:08 PST 2004 >Closed-Date: >Last-Modified: >Originator: Andrew Thompson >Release: FreeBSD 5.2-RC i386 >Organization: >Environment: System: FreeBSD kate.fud.org.nz 5.2-RC FreeBSD 5.2-RC #0: Sat Dec 13 00:52:30 NZDT 2003 andy@kate.fud.org.nz:/usr/obj/usr/src/sys/KATE i386 >Description: A user can set tz_requested via the tzX.active sysctl. The thermal states sort from hot to cold where 0 has the most cooling power. (AFAIK :) The current logic means that if a user sets it to a lower cooling (e.g 3) it will not go to 2,1 or 0 (more cooling). Essentially limiting the cooling. I believe it should be the other way around, where tz_requested sets the minimum cooling level, not maximum. patch attached. >How-To-Repeat: >Fix: --- sys/dev/acpica/acpi_thermal.c.orig Tue Jan 20 11:07:24 2004 +++ sys/dev/acpica/acpi_thermal.c Tue Jan 20 11:06:42 2004 @@ -436,7 +436,7 @@ } /* Handle user override of active mode */ - if (sc->tz_requested > newactive) + if (sc->tz_requested != TZ_ACTIVE_NONE && sc->tz_requested < newactive) newactive = sc->tz_requested; /* update temperature-related flags */ >Release-Note: >Audit-Trail: >Unformatted: