From owner-svn-src-head@freebsd.org Sun Nov 11 01:38:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CD8D1123AFB; Sun, 11 Nov 2018 01:38:23 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65553866A4; Sun, 11 Nov 2018 01:38:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x736.google.com with SMTP id n12so8057967qkh.11; Sat, 10 Nov 2018 17:38:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0DHYq7c6MzEeM6ko1rL2O954W7veREs1fW1ponIzbeg=; b=Qpp6tIubp44gmDkFRCJo6wvO0eI6hWXEwOSsRfmd1ul6uhd+ZGjLvU6YEF6XCKBTJ9 M4S7qTOS8R/4+0yUQqErAhjkqec239gotI8y/r53kRQehnDAkot/RoYcaDmoZrItRBcv aZqgAk74dsJYmrZinWuV3J/4TLi8fZf82JAONx/0pGUMantATPAemCx06+lqQ2OzBJz4 CINY6ahaa8t4FN0OsH88PYMw4QMqOHzVo1T/4SvgA156Zw7M/5315SScQNWPHYYaJOsa VoC9+5d8qYRYTLcjtsQjJAvM985erbnAc6yBnJ0K4InCnni5t9eqMHigT6ugv5IBNKhu 8oaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=0DHYq7c6MzEeM6ko1rL2O954W7veREs1fW1ponIzbeg=; b=Lvya6rLViqOOA/U9iEQ68wdBToeUIeq2y+s7YMhkAL463Au/sbcZeNO5ywWI3FwjiO nrC3ZucvqxVGQSdIbWrGacVAdUyFkjZY6EUOUcfkyaz3SYzsA4tEG+MYzQXFL7ZDk6J+ Uov0JUjzP0GHC/r8rwDffA7jzih+ZJDdhppjBPcfTkhIqncOuM3CKckQLaZ/8rRq2q5V lY3SkXY+pH8SzF72GTusAG8YFqXrwv0v+xOuXctD4uzgYvMgNqL3bNJyBUzYhKBwgl6j xTShwrSUyHIe/RRFVU03AvBodp5t18olqgzjkkEAOxAwD+ly9XvN7BzQZ/owGYPwwq75 aZcQ== X-Gm-Message-State: AGRZ1gIf60LtqnaCG1C3pmkCLUuFI6wm8EXB7/HqZOW09vJ54WZ3UOZF 6Laig3UlFxkRlCEnlRRTSX0/O5y0 X-Google-Smtp-Source: AJdET5d3qzn8rDuwZFIRoGLl2AS+YknGeJssElJ/GSTF//a1qTBHxfptAUm7VNG7xyENPpnmMB4OtA== X-Received: by 2002:ac8:5509:: with SMTP id j9mr13589579qtq.287.1541900301619; Sat, 10 Nov 2018 17:38:21 -0800 (PST) Received: from spy (toroon0560w-lp130-07-64-229-95-98.dsl.bell.ca. [64.229.95.98]) by smtp.gmail.com with ESMTPSA id t43sm8892155qtc.53.2018.11.10.17.38.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Nov 2018 17:38:21 -0800 (PST) Sender: Mark Johnston Date: Sat, 10 Nov 2018 20:38:16 -0500 From: Mark Johnston To: rgrimes@freebsd.org Cc: Ben Woods , Ben Woods , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340326 - head Message-ID: <20181111013816.GA2880@spy> References: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 65553866A4 X-Spamd-Result: default: False [-3.64 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[6.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.95)[-0.953,0]; IP_SCORE(-0.98)[ipnet: 2607:f8b0::/32(-2.89), asn: 15169(-1.92), country: US(-0.09)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; FREEMAIL_CC(0.00)[gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 01:38:23 -0000 On Sat, Nov 10, 2018 at 05:07:38PM -0800, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > If your going to bother with a differential, and invite people to > > > it you should give them at least 24 hours, and preferably 72 hours > > > to respond to the new review. Reviews that last < 4 hours are not > > > code reviews. > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > Hi Rod, > > > > Sorry. The main reason I submitted the code review is because I do not have > > my src commit bit, so needed to seek approval to commit. > > All the more reason for it to wait until the people you *invited* to > the review to have a chance to respond. > > I do not believe an "accept" in a review is an "approve to commit > beyond your normal scope". I think that's being pedantic. UPDATING is an English text file, no special qualification is needed to add an entry. Ben waited for two months before committing r340318; I'm sure he appreciates the need to give reviewers time to review anything controversial. > Was cem aware that he was "approving a non src committer to commit > this change to the src tree" as your review has no mention that you > are seeking src bit approval to commit there. I doubt he worried too much about the distinction. If a committer clicks "accept," it means, "the change looks good to me." Does it matter how it gets committed, at least in this trivial case? > > I felt the need to commit the UPDATING entry was time sensitive, given the > > change it was notifying users of had already been committed. That makes perfect sense to me.