From owner-svn-src-all@freebsd.org Mon Sep 12 10:00:15 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8745FBD683F; Mon, 12 Sep 2016 10:00:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 057DF824; Mon, 12 Sep 2016 10:00:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u8CA059Z081819 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 12 Sep 2016 13:00:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u8CA059Z081819 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u8CA03om081761; Mon, 12 Sep 2016 13:00:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 12 Sep 2016 13:00:03 +0300 From: Konstantin Belousov To: Sepherosa Ziehau Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305722 - head/sys/x86/x86 Message-ID: <20160912100003.GX38409@kib.kiev.ua> References: <201609120457.u8C4vw9S052665@repo.freebsd.org> <20160912083228.GW38409@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 10:00:15 -0000 On Mon, Sep 12, 2016 at 04:47:35PM +0800, Sepherosa Ziehau wrote: > On Mon, Sep 12, 2016 at 4:39 PM, Sepherosa Ziehau wrote: > > On Mon, Sep 12, 2016 at 4:32 PM, Konstantin Belousov > > wrote: > >> On Mon, Sep 12, 2016 at 04:57:58AM +0000, Sepherosa Ziehau wrote: > >>> Author: sephe > >>> Date: Mon Sep 12 04:57:58 2016 > >>> New Revision: 305722 > >>> URL: https://svnweb.freebsd.org/changeset/base/305722 > >>> > >>> Log: > >>> x86: Use sx lock for interrupt sources. > >>> > >>> - Certain pic_assign_cpu, e.g. msi_assign_cpu can have quite a long > >>> call chain. For msi_assign_cpu, mutex makes complex PCI bridge > >>> drivers more tricky, e.g. sleep can note be called, etc, it will > >>> be pretty tricky for upcoming Hyper-V PCI bridge driver for PCI > >>> pass-through. > >> > >>> - It is not used on any hot code path nor non-sleepable context, so > >>> sx should have the same effect as mutex. > >> Did you tested ACPI_DMAR interrupt remapping mode with your patch and > >> witness enabled ? > > > > Nope, I am about to try it now. BTW, I just checked the code for > > ACPI_DMAR, I didn't see anything obviously w/ the lock type change > > though. > > I didn't notice anything wrong w/ options > ACPI_DMAR+WITNESS+INVARIANTS. If you saw anything wrong, please let > me know. Options are not enough, you should explicitely enable interrupt remapping with loader tunable hw.dmar.ir=1.