Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Dec 2013 10:39:30 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Roger Pau Monne <roger.pau@citrix.com>
Cc:        xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org
Subject:   Re: [PATCH v7 15/19] xen: create a Xen nexus to use in PV/PVH
Message-ID:  <201312241039.30656.jhb@freebsd.org>
In-Reply-To: <1387479296-33389-16-git-send-email-roger.pau@citrix.com>
References:  <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-16-git-send-email-roger.pau@citrix.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, December 19, 2013 1:54:52 pm Roger Pau Monne wrote:
> Introduce a Xen specific nexus that is going to be in charge for
> attaching Xen specific devices. Remove the identify routine from Xen
> devices and instead attach them from the nexus (PV/PVH) or xenpci
> (HVM).

As with my previous mail, I would encourage you to create a xenpv0 device and 
have the xen nexus be very minimal.  This would let you leave the existing 
identify routines in place (which is cleaner / more extensible than a static 
table of devices that you explicitly add), but by having the PV-specific 
drivers attach as children of xenpv0, their identify routines would only be 
invoked when xenpv0 attached.  You can even use an identify routine for CPUs 
(see cpu_identify in sys/x86/x86/legacy.c).

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312241039.30656.jhb>