Date: Mon, 17 Feb 1997 15:16:51 +1100 From: Bruce Evans <bde@zeta.org.au> To: chuckr@glue.umd.edu, jkh@time.cdrom.com Cc: bde@FreeBSD.org, freebsd-current@freefall.freebsd.org Subject: Re: mount and df Message-ID: <199702170416.PAA13483@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> Both seem broken here. Neither can find the size of the struct ufs_args, >> which I found in sys/ufs/ufs/ufsmount.h. I don't know if this should be >> directly included in mount.c and df.c, or whether it's supposed to be > >This problem happens with a lot of things which attempt to get at the >foo_args structures (ufs_args, iso_args, msdosfs_args, etc). Just try >building /usr/src/release/sysinstall in -current to watch about 4 >instances of this error. These things are broken (not up to date with Lite2). >Probably only Bruce would know if: > > a) These should be coming in via sys/mount.h, like they used to > (though it was pretty gross to have to define things like > MSDOSFS to get msdosfs_args in scope). > > b) We should be including <foofs/foofs/foo.h> instead. Anyone merging Lite2 would know. (a) was gross for a couple of file system and unmanagable for 10-100 file systems. Lite2 fixed this. You now have to include <somewhere/something.h> headers if you want to support foofs. The only problem with this is that the foofs sources aren't well organised. I think they should be in sys/fs/foofs/*. Currently we have the following mess: foo[fs] somewhere something comments ------- --------- --------- -------- ufs ufs/ufs ffsmount nfs nfs nfsmount mfs doesn't fit, uses ufs headers msdos msdosfs msdosfsmount no fs in name lofs doesn't exist lfs doesn't fit, uses ufs headers fdesc no fs in name, no special hdrs portal miscfs/portal portal no fs in names null miscfs/nullfs null no fs in name umap miscfs/umapfs umap no fs in name kernfs no special headers procfs no special headers afs doesn't exist cd9660 isofs/cd9660 cd9660_mount no fs in name, extra _ in hdr union miscfs/union union no fs in names devfs no special headers ext2fs doesn't fit, uses ufs headers tfs doesn't exist Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702170416.PAA13483>