From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Sep 7 02:00:07 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C8037106566B for ; Sun, 7 Sep 2008 02:00:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A110D8FC19 for ; Sun, 7 Sep 2008 02:00:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m87207Yb016093 for ; Sun, 7 Sep 2008 02:00:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m872071l016092; Sun, 7 Sep 2008 02:00:07 GMT (envelope-from gnats) Resent-Date: Sun, 7 Sep 2008 02:00:07 GMT Resent-Message-Id: <200809070200.m872071l016092@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Adam Weinberger Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 765E21065675 for ; Sun, 7 Sep 2008 01:54:47 +0000 (UTC) (envelope-from adamw@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6BA458FC17 for ; Sun, 7 Sep 2008 01:54:47 +0000 (UTC) (envelope-from adamw@FreeBSD.org) Received: from freefall.freebsd.org (adamw@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m871sl7u015895 for ; Sun, 7 Sep 2008 01:54:47 GMT (envelope-from adamw@freefall.freebsd.org) Received: (from adamw@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m871sla7015894; Sun, 7 Sep 2008 01:54:47 GMT (envelope-from adamw) Message-Id: <200809070154.m871sla7015894@freefall.freebsd.org> Date: Sun, 7 Sep 2008 01:54:47 GMT From: Adam Weinberger To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/127165: Allow ${TAR} to be overridden in ghostscript8 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adam Weinberger List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2008 02:00:07 -0000 >Number: 127165 >Category: ports >Synopsis: Allow ${TAR} to be overridden in ghostscript8 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Sep 07 02:00:07 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Adam Weinberger >Release: FreeBSD 7.0-STABLE i386 >Organization: >Environment: System: FreeBSD freefall.freebsd.org 7.0-STABLE FreeBSD 7.0-STABLE #34: Sat Apr 12 11:52:18 UTC 2008 simon@freefall.freebsd.org:/usr/src/sys/i386/compile/FREEFALL i386 >Description: If you've overridden ${TAR} (say, to add other options), the invocation in the port Makefile has to be ${TAR} -options. If the Makefile uses ${TAR} options (i.e., no hyphen), tar freaks out. Attached patch simply adds hyphens before the options, and allows ${TAR} to be overridden in, for example, /etc/make.conf. >How-To-Repeat: >Fix: It's been a very long time since I've sent a PR. If I'm putting the patch in wrong, I apologize in advance. Index: Makefile =================================================================== RCS file: /home/pcvs/ports/print/ghostscript8/Makefile,v retrieving revision 1.174 diff -u -r1.174 Makefile --- Makefile 25 Jul 2008 12:24:08 -0000 1.174 +++ Makefile 7 Sep 2008 01:50:08 -0000 @@ -250,8 +250,8 @@ ${INSTALL_DATA} ${WRKSRC}/contrib/japanese/doc/* ${WRKSRC}/contrib/japanese ${MKDIR} ${DOCSDIR} cd ${WRKSRC}/contrib && \ - ${TAR} cf - ${PORTDOC_FILES} | \ - ( cd ${DOCSDIR} && ${TAR} xof - ) + ${TAR} -cf - ${PORTDOC_FILES} | \ + ( cd ${DOCSDIR} && ${TAR} -xof - ) .if defined(WITH_FT_BRIDGE) post-install-fapi: >Release-Note: >Audit-Trail: >Unformatted: