From owner-freebsd-dtrace@FreeBSD.ORG Fri Jun 21 19:00:02 2013 Return-Path: Delivered-To: freebsd-dtrace@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 75B1F9E6 for ; Fri, 21 Jun 2013 19:00:02 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-vb0-x232.google.com (mail-vb0-x232.google.com [IPv6:2607:f8b0:400c:c02::232]) by mx1.freebsd.org (Postfix) with ESMTP id 38B451026 for ; Fri, 21 Jun 2013 19:00:02 +0000 (UTC) Received: by mail-vb0-f50.google.com with SMTP id w16so6319254vbb.9 for ; Fri, 21 Jun 2013 12:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FcZ6BLgHtuaIFaw361naUGe4TZHo1H1FhpQHsGE4/fo=; b=OG56+nLRF9DmX0YYVmsoQX6nfjbRnyvR4BKdojvUGh5N7FA6dT2jDREtGuuW+nTIC0 BQxwygiINWsDcKePA35yFQt7WoET0G9goN4NEUFdYO7WxNa/vc8r4dZrDhNtcT4TIRKR boJl1WHzNp8kprPlOL5+Ft5qFWHFAd2l8gH4N3CrmUwVpY3vhuIKcuAgNf9R/eVKBxXV Mlbhuape3l6i6xKYNyHMTznF9gQX5ND5jrDJqRxR5zKD/xhdplbxVO9bFKov/qEDuhxI JBdriD1bDbdkqYoneFvOjAsMVNjUaUMLlON6dbVzyoK6VrKzHzy7fCKPvEgT60NrQfFv Awvw== X-Received: by 10.58.85.161 with SMTP id i1mr6267119vez.97.1371841201802; Fri, 21 Jun 2013 12:00:01 -0700 (PDT) Received: from charmander.mks.com ([198.73.105.231]) by mx.google.com with ESMTPSA id ih10sm6866380vdb.1.2013.06.21.12.00.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Jun 2013 12:00:01 -0700 (PDT) Sender: Mark Johnston Date: Sat, 22 Jun 2013 03:00:25 -0400 From: Mark Johnston To: Jeff Ford Subject: Re: Patch for the trap handler and some test list sanity Message-ID: <20130622070025.GA14663@charmander.mks.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-dtrace@freebsd.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jun 2013 19:00:02 -0000 On Fri, Jun 21, 2013 at 11:47:43AM -0700, Jeff Ford wrote: > Anton Rang and I did some DTrace work for Isilon that we're trying to get > back into FreeBSD, but neither of us is a committer - here's the first one. > > This moves the check for dtrace trap handlers into the low-level exception > handler to prevent recursive entry when the trap routine is instrumented. > This fixes several tests which previously panicked including > cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/safety/tst.basename.d. > The fix is AMD64 only – neither of us has had time to make changes to i386 > code as we don’t use it here. > > Also this includes updates to the Makefile for the DTrace tests to > categorize which ones pass, which ones fail, which ones aren’t safe to run > at all, and which ones sometimes pass and sometimes fail. The list should > be correct for both AMD64 and i386. This makes “make”, “make ignore”, and > “make flaky” safe to run in /tools/test/dtrace. Hello, I'd be happy to help bring these in. I'll probably need some help reviewing the first one, but "improve the DTrace test makefile" has been on my todo list for a while. Are they available somewhere? -Mark