From owner-freebsd-ia64@FreeBSD.ORG  Mon Feb 14 14:39:55 2005
Return-Path: <owner-freebsd-ia64@FreeBSD.ORG>
Delivered-To: freebsd-ia64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A49A716A4CE
	for <freebsd-ia64@freebsd.org>; Mon, 14 Feb 2005 14:39:55 +0000 (GMT)
Received: from mailgate.hob.de (mailgate.hob.de [62.91.19.101])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2050243D2D
	for <freebsd-ia64@freebsd.org>; Mon, 14 Feb 2005 14:39:55 +0000 (GMT)
	(envelope-from christian.kandeler@hob.de)
Received: from localhost (localhost [127.0.0.1])
	by mailgate.hob.de (Postfix) with ESMTP id C0AC9153C35
	for <freebsd-ia64@freebsd.org>; Mon, 14 Feb 2005 15:39:53 +0100 (CET)
Received: from imap.hob.de (mail2.hob.de [172.25.1.102])
	by mailgate.hob.de (Postfix) with ESMTP id C11B5153C14
	for <freebsd-ia64@freebsd.org>; Mon, 14 Feb 2005 15:39:48 +0100 (CET)
Received: from linux03.hob.de (linux03.hob.de [172.22.0.190])
	38A572832
	for <freebsd-ia64@freebsd.org>; Mon, 14 Feb 2005 15:39:48 +0100 (CET)
From: Christian Kandeler <christian.kandeler@hob.de>
Organization: HOB
To: freebsd-ia64@freebsd.org
Date: Mon, 14 Feb 2005 15:39:48 +0100
User-Agent: KMail/1.6.2
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <200502141539.48180.christian.kandeler@hob.de>
X-Virus-Scanned: by AMaViS perl-11
Subject: FWSPA 
X-BeenThere: freebsd-ia64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the IA-64 <freebsd-ia64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ia64>,
	<mailto:freebsd-ia64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ia64>
List-Post: <mailto:freebsd-ia64@freebsd.org>
List-Help: <mailto:freebsd-ia64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ia64>,
	<mailto:freebsd-ia64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2005 14:39:55 -0000

Hi,

in the ia64_init() function, the fpswa is initialized as follows:

    fpswa_interface = (FPSWA_INTERFACE*)IA64_PHYS_TO_RR7(bootinfo.bi_fpswa);

Shouldn't it be tested here whether bootinfo.bi_fpswa is NULL? It would make 
the follwing test in cpu_startup() much more meaningful:

	if (fpswa_interface == NULL)
		printf("Warning: no FPSWA package supplied\n");
	else
		printf("FPSWA Revision = 0x%lx, Entry = %p\n",
		    (long)fpswa_interface->Revision,
		    (void *)fpswa_interface->Fpswa);

As of now, this will always execute the else branch, because bootinfo.bi_fpswa 
was unconditionally or'ed with 7 << 61 and the result can therefore not be 
NULL. 
Or am I missing something?


Christian