From owner-freebsd-ports@FreeBSD.ORG Wed Jul 23 15:38:56 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 786DD106567C for ; Wed, 23 Jul 2008 15:38:56 +0000 (UTC) (envelope-from florent.thoumie@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.182]) by mx1.freebsd.org (Postfix) with ESMTP id 382CE8FC15 for ; Wed, 23 Jul 2008 15:38:56 +0000 (UTC) (envelope-from florent.thoumie@gmail.com) Received: by py-out-1112.google.com with SMTP id p76so1774916pyb.10 for ; Wed, 23 Jul 2008 08:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=FOxXwriSnjUaVVS9lOcvYyUTvcmnP6zUPVMYJsKL8iw=; b=I8VgfR8J4/4Uk/MBYMJ94jmuC20C0Ho/De+YS4Yrym6D23+CMB0CkG3F6hbRm31t3p 11eOM6/l9Cpw/qmutpkgZFQEIb8SBhyRgU5b+DzL0/dT/hBTYqEyXWEQfVoSmcZSeQlB SNRJ68lqpKQyUYZvbqbI4YWH36XApGtJNn0Cg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=JOHCHaM5gWNO8nbtx4FX9aBxcD19cDSUf5kOfgFN67Hrx4xGxSUDECXzyiqfYrKSnu pDIxhEb68/NGuolWGIfBblKRIZ4Ev8FNQL2WRWA7Fl1Vk1NP9/j94mMxncQwjVNrF23T VLRpjmkr6ED9BFXQDAJrNqhVviojcoApIMPrY= Received: by 10.115.14.1 with SMTP id r1mr129551wai.206.1216827535048; Wed, 23 Jul 2008 08:38:55 -0700 (PDT) Received: by 10.114.60.15 with HTTP; Wed, 23 Jul 2008 08:38:54 -0700 (PDT) Message-ID: Date: Wed, 23 Jul 2008 16:38:54 +0100 From: "Florent Thoumie" Sender: florent.thoumie@gmail.com To: "Philip M. Gollucci" In-Reply-To: <48874AB6.6080604@p6m7g8.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> <20080723151212.18dfb88d@it.buh.tecnik93.com> <48874AB6.6080604@p6m7g8.com> X-Google-Sender-Auth: bfc4893b69b08e3b Cc: ports@freebsd.org, Olafur Osvaldsson , pgollucci@freebsd.org, Ion-Mihai Tetcu , araujo@freebsd.org Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 15:38:56 -0000 On Wed, Jul 23, 2008 at 4:13 PM, Philip M. Gollucci wrote: > Florent Thoumie wrote: >> >> On Wed, Jul 23, 2008 at 1:12 PM, Ion-Mihai Tetcu >> wrote: >>> >>> On Wed, 23 Jul 2008 13:08:03 +0100 >>> "Florent Thoumie" wrote: >>> >>>> On Wed, Jul 23, 2008 at 12:30 PM, Olafur Osvaldsson >>>> wrote: >>>>> >>>>> This is something the PR responsible introduced in his original >>>>> patch... >>>> >>>> It's still present in your version. Anyway, I'm not blaming anyone, >>>> just pointing out what I think is a mistake. >>> >>> So this is not for the user but for the port? >>> >>> I'll do a swap on the tree for it, because I'm sure there are more >>> ports doing something like: >>> .ifndef(NO_INSTALL_MANPAGES) >>> ...... >>> .endif > > I was talking to itectu@ about this, and figured it would be better in > Mk/bsd.port.mk. > > >> The general rule of thumb is: if it doesn't begin with WITH_ or >> WITHOUT_, it's not user-settable. NO_INSTALL_MANPAGES is used for >> ports using imake that don't understand the install.man target. > > /me thought that was the USE_ vs WITH(OUT)?_ difference. > > NO* is supposed to be user settable right ? Have a look at variables in bsd.port.mk. You should have your answer. >> Now of course there are exceptions (usually for no good reason IMHO). >> The likes of NOPORTDOCS/NOPORTEXAMPLES/... could be changed to >> WITHOUT_DOCS/WITHOUT_EXAMPLES, it's just waiting for somebody to do >> the work. > > Heh, maybe, I kind of feel like it will get reject as a style(9) change. This is not a gratuitous change. The issue isn't to get it approved, it's to get the work done. Not having coherent namespaces leads to people using USE_GNOME=yes in /etc/make.conf and wondering why every single port depends on gnome. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer