Date: Mon, 10 Oct 2011 13:27:59 -0700 From: Qing Li <qingli@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226224 - head/sys/netinet Message-ID: <CAGnGRdLmhDu8LdN0o9M3WP9EPy7-bBq7XtHq20Cqq%2BjRX9rTbQ@mail.gmail.com> In-Reply-To: <20111010201502.GD94905@FreeBSD.org> References: <201110101741.p9AHfB6E073485@svn.freebsd.org> <20111010201502.GD94905@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
MFC 225946 is the original patch, 225947 messed up the logic a bit while putting in the fix for another issue. 226224 is the fix to 225947, which I will MFC tomorrow. --Qing 2011/10/10 Gleb Smirnoff <glebius@freebsd.org>: > =A0Qing, > > On Mon, Oct 10, 2011 at 05:41:11PM +0000, Qing Li wrote: > Q> Author: qingli > Q> Date: Mon Oct 10 17:41:11 2011 > Q> New Revision: 226224 > Q> URL: http://svn.freebsd.org/changeset/base/226224 > Q> > Q> Log: > Q> =A0 All indirect routes will fail the rtcheck, except for a special ho= st > Q> =A0 route where the destination IP and the gateway IP is the same. Thi= s > Q> =A0 special case handling is only meant for backward compatibility rea= son. > Q> =A0 The last commit introduced a bug in the route check logic, where a > Q> =A0 valid special case is treated as an error. This patch fixes that b= ug > Q> =A0 along with some code cleanup. > Q> > Q> =A0 Suggested by: =A0 =A0 =A0gleb > Q> =A0 Reviewed by: =A0 =A0 =A0 kmacy, discussed with gleb > Q> =A0 MFC after: 1 day > > =A0Looks like you have committed a slightly different patch to stable/8 > in r226230. Is that okay? > > =A0Also, you haven't awaited even one day, while our policy suggests at > least 3 days before MFC, and 3 days is actually a delay for critical > fixes. > > P.S. Now I am not the only Gleb at FreeBSD.org community. Recently > Gleb Kurtsou joined us, and his login name is exactly "gleb", while > mine is "glebius". So, your commit may be confusing to later > reviewers of VCS history. > > -- > Totus tuus, Glebius. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGnGRdLmhDu8LdN0o9M3WP9EPy7-bBq7XtHq20Cqq%2BjRX9rTbQ>