From owner-svn-src-all@FreeBSD.ORG Tue Dec 7 11:26:10 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A8D1106566B; Tue, 7 Dec 2010 11:26:10 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id D519B8FC08; Tue, 7 Dec 2010 11:26:09 +0000 (UTC) Received: by qyk8 with SMTP id 8so4443247qyk.13 for ; Tue, 07 Dec 2010 03:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=wsqvDnCmjjohrnE3qQgSFa3/yU/JkwDWD7GohmJffuA=; b=xSKh+vFwpXq0nGAM0foE/hZPuWuD3DXn5U9ra9JAoZpfNZBSRbInokAf3tqqpWFRg3 TOqhKgdBKrCc7odE3VO4edtp6R6LP0gRu+VfqiT1Bu+fLMprdPsqaVnZzg0OmsHNQMd2 MUroQ7Sy5thMs9LPdiV021XcXO1Z0b809a7Ek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=j8s1j3Q69lrBKWrKfhq4ACGwwRHv76L0jbWGInxJ39Qq1PBDkRveZAaPHJHp1uu3g3 yA48YhTuUpERnugTKFLsE30fqp6qsbiZvSWf+1giEGSH3QgksJLbyLBafLDrAbElJEE+ liqsUE8ixyl2hGHE9a9K6zs3ogwOelgRwQq/o= Received: by 10.229.228.146 with SMTP id je18mr5673790qcb.47.1291721168938; Tue, 07 Dec 2010 03:26:08 -0800 (PST) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.231.143 with HTTP; Tue, 7 Dec 2010 03:25:28 -0800 (PST) In-Reply-To: <20101207102104.GD1700@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> <20101206192238.GB1936@garage.freebsd.pl> <20101206195327.GD1936@garage.freebsd.pl> <20101207102104.GD1700@garage.freebsd.pl> From: Ivan Voras Date: Tue, 7 Dec 2010 12:25:28 +0100 X-Google-Sender-Auth: t4nGlXLutMez1lV-zFrE3_ZDoIg Message-ID: To: Pawel Jakub Dawidek Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2010 11:26:10 -0000 On 7 December 2010 11:21, Pawel Jakub Dawidek wrote: > PS. Do you know your change breaks all current ZFS installation if > stripesize is defined for a provider? > > =C2=A0 =C2=A0 =C2=A0 =C2=A0# zpool create tank ada0 > =C2=A0 =C2=A0 =C2=A0 =C2=A0(upgrade FreeBSD so that ada0 now reports 4kB = stripesize) > =C2=A0 =C2=A0 =C2=A0 =C2=A0# zpool import tank > =C2=A0 =C2=A0 =C2=A0 =C2=A0cannot import 'tank': invalid vdev configurati= on Actually I did test the patch and, similar to the Solaris people, found that ZFS records ashift in metadata and uses the recorded one instead of hardcoded / detected one. What you found here really shouldn't happen. Are you sure only stripesize was increased in your case, not sectorsize? > So you change was not only poorly thought out and not reviewed, but also > not even minimally tested. Before we go any further, back it out. This actually is the first problem that requires backing it out. I will do = it.