From nobody Fri May 24 11:48:03 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vm3Fd4gyCz5MKcL; Fri, 24 May 2024 11:48:05 +0000 (UTC) (envelope-from rnagy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vm3Fd47Dpz4V1X; Fri, 24 May 2024 11:48:05 +0000 (UTC) (envelope-from rnagy@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716551285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gpEuVy8JzdYIBxlAWW4z9cVR49ivJsuVWoPkoFq3mkU=; b=wLxwuMulQvSe77DTpMkivD2falGOgX8CENTOoX1pkvvm5u0O0JuMeswTQsYxT+2k6UKvNZ pfmfFT7iHkYnIaR57tT6fFJguiDdSp2ytiSkL8hvoC6btpA1zB2SXJEsa1t11wisepY8sa 5AMAsBJebz6ZED8tB5Tj9lFE09oLLigL2iR/T0ZaXLoNDpfM8QN3qN4RbPyKpWwpuXuwK3 jhkh0It7EOMGQSUh1LN67puLh+Apzb2+q08La9dvkiM72ns2b0WU1v4Sgt1s5+IAw9OHcI NMdsi5BvLnjr2zhJ6lVAoOpXRUMxmGa9uzjtJpL4P8+rcxj0Xs1lMsWh/WYsGQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716551285; a=rsa-sha256; cv=none; b=lTNgHHCf92hTMWsLsga4jK7lxGIa4J367mQO4zNTCiUavsbApJt3mGoNYV4p0d9cfn3Cnk /Ph7EEFVzPc0Bi5pZO7TZT7hJzR9c7L3Qmudka1sZ5JyVVf2YjUa7CwaTziuJz9TrEr8n2 +fle9DJe6Ef1nzZjIT6R15B3odtMmjFd3jlxR7UdqycEsSGkMnarLAYzIs2h/gmTb4JQ5/ H6gAaQ0sv49M7Hfh3c3w9jY7GAZ5VA+1IpBI1cGCg5fhOjmVLjinxGnvjpPlEvNVVKDH+Y XDfHY6cCXw+12Yd8y2XZUebwQF5MFUtUdfR5ChMu1C2hX2LNaddiapplqEAWQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716551285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gpEuVy8JzdYIBxlAWW4z9cVR49ivJsuVWoPkoFq3mkU=; b=Xh3JbNQ6sRr3hqgDI3wIoYAyiWAjsaXpss45MsnV2T6hc+2zDFNm1F+MqMwl2CnbSTIR9j 6G33HMhSkY/AA3y7/Hi/0yyyfvheAJcfNIznFBk9cL/ww3GTFVpqW4IRjP2P9vV7lo9E7M m7mre67wCs1COE1l895tC0mMp6bPCfcHcXTtgD42rQ/KnPVFlLNN0IyqskGSjr6RDn2Ep2 0nZ6/RK8NHwMj+7ttJ1FDjJ/DVj6ciYSBcV8fBQwamXvffUVUEAOgKf4F0fWXdI7QUcEtO lfmxjbASemeSKOgpTbHMs46KpH7fcSTswxvma66EXrUUrYzSqhKRpll5zbNfag== Received: from freebsd.org (nerd.hu [84.2.34.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) (Authenticated sender: rnagy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vm3Fc6tPpzf5G; Fri, 24 May 2024 11:48:04 +0000 (UTC) (envelope-from rnagy@freebsd.org) Date: Fri, 24 May 2024 13:48:03 +0200 From: Robert Nagy To: Vladimir Druzenko Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b4d0a174c529 - main - www/ungoogled-chromium: update to 125.0.6422.76 and implement selectable audio backend support Message-ID: References: <202405240347.44O3le5k098915@gitrepo.freebsd.org> <857780ad-a8d7-4075-8468-8aba187897f4@freebsd.org> <39c1974d-1a50-4c19-a0df-38d3f6db86cb@freebsd.org> <2f18d1f9-4e14-4f8c-841d-0d04d6f69d52@freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2f18d1f9-4e14-4f8c-841d-0d04d6f69d52@freebsd.org> On 24/05/24 14:45 GMT, Vladimir Druzenko wrote: > 24.05.2024 14:36, Robert Nagy пишет: > > On 24/05/24 14:07 GMT, Vladimir Druzenko wrote: > > > 24.05.2024 13:40, Robert Nagy пишет: > > > > On 24/05/24 12:51 GMT, Vladimir Druzenko wrote: > > > > > 24.05.2024 06:47, Robert Nagy пишет: > > > > > > The branch main has been updated by rnagy: > > > > > > > > > > > > URL:https://cgit.FreeBSD.org/ports/commit/?id=b4d0a174c529e8061d838aafba1721cc317af01f > > > > > > > > > > > > commit b4d0a174c529e8061d838aafba1721cc317af01f > > > > > > Author: Robert Nagy > > > > > > AuthorDate: 2024-05-23 20:21:23 +0000 > > > > > > Commit: Robert Nagy > > > > > > CommitDate: 2024-05-24 03:47:31 +0000 > > > > > > > > > > > > www/ungoogled-chromium: update to 125.0.6422.76 and implement selectable audio backend support > > > > > > with these changes, chromium now automatically selects which > > > > > > audio backend to use in the following order: > > > > > > pulse (if running) -> sndio -> alsa -> fake > > > > > > an additional command line option has been also implemented so > > > > > > that the user can force which backend to use: > > > > > > --audio-backend={auto,sndio,pulse,alsa} > > > > > > Security:https://vuxml.freebsd.org/freebsd/8247af0d-183b-11ef-9f97-a8a1599412c6.html > > > > > > --- > > > > > > > > > > > > @@ -19,7 +19,8 @@ ONLY_FOR_ARCHS= aarch64 amd64 i386 > > > > > > PATCH_DEPENDS= gpatch:devel/patch \ > > > > > > ${PYTHON_VERSION}:lang/python${PYTHON_SUFFIX} > > > > > > -BUILD_DEPENDS= bash:shells/bash \ > > > > > > +BUILD_DEPENDS= ${LOCALBASE}/include/pulse/pulseaudio.h:audio/pulseaudio \ > > > > > > + bash:shells/bash \ > > > > > > ${PYTHON_PKGNAMEPREFIX}Jinja2>0:devel/py-Jinja2@${PY_FLAVOR} \ > > > > > > ${PYTHON_PKGNAMEPREFIX}ply>0:devel/py-ply@${PY_FLAVOR} \ > > > > > > gperf:devel/gperf \ > > > > > > @@ -38,8 +39,10 @@ BUILD_DEPENDS= bash:shells/bash \ > > > > > > LIB_DEPENDS= libatk-bridge-2.0.so:accessibility/at-spi2-core \ > > > > > > libatspi.so:accessibility/at-spi2-core \ > > > > > > libspeechd.so:accessibility/speech-dispatcher \ > > > > > > + libasound.so:audio/alsa-lib \ > > > > > > libFLAC.so:audio/flac \ > > > > > > libopus.so:audio/opus \ > > > > > > + libsndio.so:audio/sndio \ > > > > > > libspeex.so:audio/speex \ > > > > > > libdbus-1.so:devel/dbus \ > > > > > > libdbus-glib-1.so:devel/dbus-glib \ > > > > > > @@ -154,10 +162,8 @@ SUB_FILES= ungoogled-chromium.desktop ungoogled-chromium > > > > > > SUB_LIST+= COMMENT="${COMMENT}" > > > > > > OPTIONS_DEFINE= CODECS CUPS DEBUG DRIVER KERBEROS LTO PIPEWIRE TEST WIDEVINE > > > > > > -OPTIONS_DEFAULT= CODECS CUPS DRIVER KERBEROS PIPEWIRE SNDIO > > > > > > +OPTIONS_DEFAULT= CODECS CUPS DRIVER KERBEROS PIPEWIRE > > > > > > OPTIONS_EXCLUDE_aarch64=LTO > > > > > > -OPTIONS_GROUP= AUDIO > > > > > > -OPTIONS_GROUP_AUDIO= ALSA PULSEAUDIO SNDIO > > > > > > OPTIONS_RADIO= KERBEROS > > > > > > OPTIONS_RADIO_KERBEROS= HEIMDAL HEIMDAL_BASE MIT > > > > > > OPTIONS_SUB= yes > > > > > > @@ -167,12 +173,6 @@ HEIMDAL_BASE_DESC= Heimdal Kerberos (base) > > > > > > HEIMDAL_DESC= Heimdal Kerberos (security/heimdal) > > > > > > MIT_DESC= MIT Kerberos (security/krb5) > > > > > > -ALSA_LIB_DEPENDS= libasound.so:audio/alsa-lib > > > > > > -ALSA_RUN_DEPENDS= ${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:audio/alsa-plugins \ > > > > > > - alsa-lib>=1.1.1_1:audio/alsa-lib > > > > > > -ALSA_VARS= GN_ARGS+=use_alsa=true > > > > > > -ALSA_VARS_OFF= GN_ARGS+=use_alsa=false > > > > > > - > > > > > > CODECS_VARS= GN_ARGS+=proprietary_codecs=true \ > > > > > > FFMPEG_BRAND="Chrome" > > > > > > CODECS_VARS_OFF= GN_ARGS+=proprietary_codecs=false \ > > > > > > @@ -216,18 +216,6 @@ PIPEWIRE_VARS= GN_ARGS+=rtc_use_pipewire=true \ > > > > > > PIPEWIRE_VARS_OFF= GN_ARGS+=rtc_use_pipewire=false \ > > > > > > GN_ARGS+=rtc_link_pipewire=false > > > > > > -PULSEAUDIO_LIB_DEPENDS= libpulse.so:audio/pulseaudio > > > > > > -PULSEAUDIO_VARS= GN_ARGS+=use_pulseaudio=true > > > > > > -PULSEAUDIO_VARS_OFF= GN_ARGS+=use_pulseaudio=false > > > > > > - > > > > > > -# With SNDIO=on we exclude audio_manager_linux from the build (see > > > > > > -# media/audio/BUILD.gn) and use audio_manager_openbsd which does not > > > > > > -# support falling back to ALSA or PulseAudio. > > > > > > -SNDIO_PREVENTS= ALSA PULSEAUDIO > > > > > > -SNDIO_LIB_DEPENDS= libsndio.so:audio/sndio > > > > > > -SNDIO_VARS= GN_ARGS+=use_sndio=true > > > > > > -SNDIO_VARS_OFF= GN_ARGS+=use_sndio=false > > > > > > - > > > > > > WIDEVINE_DESC= Depend on foreign-cdm to enable playback of DRM content > > > > > > WIDEVINE_RUN_DEPENDS= foreign-cdm>0:www/foreign-cdm > > > > > Please remove mandatory dependency (BUILD and LIB) from pulse and sndio and > > > > > return build options. > > > > > You can do with OPTIONS_DEFAULT what you want, but don't force install all > > > > > these dependencies even for build. > > > > I am sorry but I don't concur. Knobs are bad, there is literally no reason for someone > > > > not to install sndio (which is the most supported by chrome) by default. > > > I'm using alsa only build. > > > > Pulseaudio is only a build dependency which is completely fine. > > > No. It isn't fine. I don't want pulseaudio on my host - it break my sound. > > Pulseaudio does not start by default at all, it will not get used unless you have > > the daemon running and even then you can disable it with the new command line flag > > of chromium and use whichever audio backend you want by default. > > > > > > I am trying to remove even more build options. They make absolutely no sense. > > > You want to remove one of the most important advantages of the FreeBSD. > > It would make sense to have an option if it would pull it in as a run or lib dependency, > > but it does not, however I will look into it to see if we could build it without even > > having pulseaudio as a build dependency. > > After I install pulseaudio and reboot (without start it via rc.conf) I lost > sound. > Please return back options that allow build and run this port without > installing pulseaudio and sndio. Please use --audio-backend=alsa.