From nobody Fri Apr 24 00:54:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1vcS0xMXz6bW2p for ; Fri, 24 Apr 2026 00:54:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1vcR5llqz3Q0f for ; Fri, 24 Apr 2026 00:54:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776992071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BrNGagBkrGhpEzKKV0leTXZ77Ngr8TLWgOoYqgcTMh4=; b=OxfuUmHvE8XKHkE52aazxUwDpqLigX++s6PEBD2yaMampTGhmzj12Ko9hP/9XbQ23U+JIG eumt66JFKKYMIPyhFnGgdtVYjv4sruwoW/JXYEPItPWTt0IgW3FYlCGre8Ps33CuA2QrFI ivRL2Q2QJoV7OZk1Xr/bR9vF2wAZqK2G49gZupB6QU/UTJ1CKv5FVvfFwlMkJXVvtRpgxo EmkL1sZp0Gfuw5fybYnIGwjhFwoCk6NPx2HXxr89lksWBh4zNJBf2ey3UwbRPlgw9lzJkN naqXHaJ7D9y22fPuuNq6D6QbfgZBHZA+ueWrdBiCA/wK5E9RmZcVA5EmrEqaRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776992071; a=rsa-sha256; cv=none; b=OUX4X+d+uLagylunWXKLjFqWTx8jsdfqNZeNV6BBq1jg4Cyu+PNA7582pf3tOu9xizP0co vcC8DuHR9ENwQpaqVrjmZCXxkNo5ctXLIZG46KkBDG2TypMvNU/86c2/p63vST00FBlNDI Y8dQRkKT1JfN6b5dO7CtADNV6MwrtGtGhfRKdv0GC5/V2ff+y1L91jeNK4pSuwgyQFKGS2 iX7/x700Mjp0Q3Cfd1hCOMBTIe71TE5wca6aUxl6WDVpDLtfjyf3KbM35YYEX7rKtAAESv b3nlPgAGaPIkma37sO4zxsCEyp3mqu/0BxHejWQIIqj6ApCk3T27C9rus24mSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776992071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BrNGagBkrGhpEzKKV0leTXZ77Ngr8TLWgOoYqgcTMh4=; b=oQRVNkyXNE1KpMHJG+xWRH+HPWsrA17yG1kW5/yRczlc6Zyi+LT8n3CweNZoYjwXIaeJbu JW2FHlaZX1+51wjjjWLVDcNeqSWOMej5rrHtsikaULrmVE4e3HTyHzvIxbbGvlNDpAo5+j LpNENBIeIr0lTg/16smoUCpDcDPKf8eL+VMWFCLmDqlKaIQixNF/3UhYS63BORNpUpo3pi PRjvUURQLaVe08z5GKNbSLntVgUGXyY86RCx0ZzvnqfiejDUcSCnebovRQbsGVSRsHBOLQ L+o6n4XyjbKCDG2qucb051eTDwRtckEOEGus/h/1DWHRWKxxNwXHo41CMW9pNg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g1vcR5Ck5zhHK for ; Fri, 24 Apr 2026 00:54:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 213df by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 00:54:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Christos Longros From: Jose Luis Duran Subject: git: 2d2f92194f07 - stable/14 - ping6: treat setsockopt failures as fatal List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2d2f92194f0776c89afcbc1244fcc8e1de69107e Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 00:54:31 +0000 Message-Id: <69eabf47.213df.65263a01@gitrepo.freebsd.org> The branch stable/14 has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=2d2f92194f0776c89afcbc1244fcc8e1de69107e commit 2d2f92194f0776c89afcbc1244fcc8e1de69107e Author: Christos Longros AuthorDate: 2026-04-17 18:19:24 +0000 Commit: Jose Luis Duran CommitDate: 2026-04-24 00:52:26 +0000 ping6: treat setsockopt failures as fatal ping6 needs IPV6_RECVPKTINFO and IPV6_RECVHOPLIMIT to process incoming replies. When these options fail, replies are silently dropped and ping6 appears to hang. Use err(3) instead of warn(3) so the user gets a clear error and immediate exit. Signed-off-by: Christos Longros Reviewed by: pouria, jlduran, glebius MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D56237 (cherry picked from commit 9a4a9f623bbaf991b3ba580593d47f2ee9f7b03b) --- sbin/ping/ping6.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/ping/ping6.c b/sbin/ping/ping6.c index afbaba33e4f7..de2f34dd78db 100644 --- a/sbin/ping/ping6.c +++ b/sbin/ping/ping6.c @@ -1096,21 +1096,21 @@ ping6(int argc, char *argv[]) #ifdef IPV6_RECVPKTINFO if (setsockopt(srecv, IPPROTO_IPV6, IPV6_RECVPKTINFO, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_RECVPKTINFO)"); /* XXX err? */ + err(1, "setsockopt(IPV6_RECVPKTINFO)"); #else /* old adv. API */ if (setsockopt(srecv, IPPROTO_IPV6, IPV6_PKTINFO, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_PKTINFO)"); /* XXX err? */ + err(1, "setsockopt(IPV6_PKTINFO)"); #endif #endif /* USE_SIN6_SCOPE_ID */ #ifdef IPV6_RECVHOPLIMIT if (setsockopt(srecv, IPPROTO_IPV6, IPV6_RECVHOPLIMIT, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_RECVHOPLIMIT)"); /* XXX err? */ + err(1, "setsockopt(IPV6_RECVHOPLIMIT)"); #else /* old adv. API */ if (setsockopt(srecv, IPPROTO_IPV6, IPV6_HOPLIMIT, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_HOPLIMIT)"); /* XXX err? */ + err(1, "setsockopt(IPV6_HOPLIMIT)"); #endif cap_rights_clear(&rights_srecv, CAP_SETSOCKOPT);