Date: Mon, 26 Sep 2005 13:50:01 -0400 From: John Baldwin <jhb@FreeBSD.org> To: freebsd-hackers@freebsd.org, frank@exit.com Subject: Re: Oddity in libufs. Message-ID: <200509261350.02589.jhb@FreeBSD.org> In-Reply-To: <1127618793.38683.9.camel@realtime.exit.com> References: <1127618793.38683.9.camel@realtime.exit.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 24 September 2005 11:26 pm, Frank Mayhar wrote:
> I've been using libufs as the I/O mechanism for my (heavy) modification
> of sysutils/ffsrecov. It's working to my needs and now I'm poking at
> other bits and pieces to maybe get it suitable for release into the
> wild. I just looked at cgread() to see what it does and noticed that
> there seems to be a redundant line:
>
> .
> .
> if (c >= fs->fs_ncg) {
> return (0);
> }
> ccg = fsbtodb(fs, cgtod(fs, c)) * disk->d_bsize;
> if (bread(disk, fsbtodb(fs, cgtod(fs, c)),
> disk->d_cgunion.d_buf,
> .
> .
>
> That assignment up there looks redundant, as ccg is never used. I
> suspect that it's a relic of an old lseek()/read() pair that's long
> gone.
The person you probably want to ask is jmallett@. I can't find anything in
cvs annotate or in the p4 depot to give history on how that got there. On
the face of it, it looks like it shouldn't cause any harm to just remove ccg.
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509261350.02589.jhb>