From owner-dev-commits-ports-main@freebsd.org Thu Sep 30 21:23:52 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B53FC670759; Thu, 30 Sep 2021 21:23:52 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HL5pG4Lr2z4tRr; Thu, 30 Sep 2021 21:23:50 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id DB1EAEC043; Thu, 30 Sep 2021 23:23:46 +0200 (CEST) Date: Thu, 30 Sep 2021 23:23:44 +0200 From: Piotr Kubaj To: Jan Beich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* Message-ID: References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ShryPTP3AdZgwy6I" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4HL5pG4Lr2z4tRr X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.37 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; ARC_NA(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.98)[-0.985]; NEURAL_HAM_SHORT(-0.99)[-0.990]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 21:23:52 -0000 --ShryPTP3AdZgwy6I Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No, I don't have a Google account. On 21-09-30 21:50:21, Jan Beich wrote: > Piotr Kubaj writes: >=20 > > The include in cpu.cc is not actually necessary, so I did not inclu= de anything for FreeBSD. > [...] > > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC > > ++++ tools/cpu/cpu.cc > > +@@ -19,7 +19,9 @@ > > + #endif > > +=20 > > + #if JXL_ARCH_PPC > > +-#include // __ppc_get_timebase_freq > > ++#if linux > > ++#include // NOLINT __ppc_get_timebase_freq > > ++#endif > > + #endif >=20 > Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? > That include is probably unused even on Linux after 5175d11717f3 > removed __ppc_get_timebase_freq. >=20 > Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream > will refuse to read the rationale (PR description), let alone the patch e= =2Eg., > https://github.com/libjxl/libjxl/pull/193 --ShryPTP3AdZgwy6I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFWKuAACgkQelmbhSCD nJ0CuA/9HSVRQ47juSmnHxvdX+Xz+EJQcgr7L3nHFJcsQ5UyuRVDo3fDlydtQ93s LBX9YF5Z1VMH4RyqzkqgWMbWQPh57nE4XaDwP1cfmvWJrNDpLQceBdEbAQivMxhb LFw9r+gPabc4aig4T5fVmQccLaubBnjHtiBxK9YW8kb2UvnWj3oMXq1+fbyM/QZB lQo6pZMZ+o5hpbtxxOJcf3RvsWUYFsDTdjXbFR3Sp+WcHH2+3CVcdzBSOTCoMwmk VZLtXiZGKxEJQ46Bjl4fuYliL7Asr7ZmqTCDhTo6m1/JrxVrmcZf8qXngECS+i8T LvclJG73qUw+bJxhSDfiCWvgaHI8g/Jb5cElnMjIUELvDbH38DiqW51kpVC5NKE3 iLYyIxhQiJgST5xpdjJi/sSgkbYeWi/g+q0rXCFX5W2vpJ15mZChNtX+JTy2Vf+t jeOj2AXSd8Psmb+JVuSE2kO2S5pVqaaDNDGlNx9+X4b+GcKDMZK1D8/bGpfGjfzP 64IJkebJUWHFG49BmUWVxN77wMTMK9LbI04XFhiyc2YldEUVsGr+a1vxWkO81tcx o5oVKY4tqxWVeAmnTQ3jyTRL29KK7yLQKTbHJ0Qu+lxFCf2K2uAasu8lEQOQyQdB 7jTWW4BGXORuUu9yTXLmVAVoTPEGeIn9V0F/FiZUZ/jZlE5VyoM= =lTub -----END PGP SIGNATURE----- --ShryPTP3AdZgwy6I--