From owner-freebsd-hackers@FreeBSD.ORG Fri May 9 16:58:33 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBDA337B404 for ; Fri, 9 May 2003 16:58:32 -0700 (PDT) Received: from smtp-relay.omnis.com (smtp-relay.omnis.com [216.239.128.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BCCD43FAF for ; Fri, 9 May 2003 16:58:32 -0700 (PDT) (envelope-from wes@softweyr.com) Received: from salty.rapid.stbernard.com (corp-2.ipinc.com [199.245.188.2]) by smtp-relay.omnis.com (Postfix) with ESMTP id BF9111C8F9; Fri, 9 May 2003 16:58:31 -0700 (PDT) From: Wes Peters Organization: Softweyr.com To: "Poul-Henning Kamp" , "Artem 'Zazoobr' Ignatiev" Date: Fri, 9 May 2003 16:58:31 -0700 User-Agent: KMail/1.5 References: <14500.1052516232@critter.freebsd.dk> In-Reply-To: <14500.1052516232@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200305091658.31285.wes@softweyr.com> cc: freebsd-hackers@freebsd.org Subject: Re: solaris/x86 disklabel geom class X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2003 23:58:33 -0000 On Friday 09 May 2003 14:37, Poul-Henning Kamp wrote: > In message <20030510005944.A53407@memphis.mephi.ru>, "Artem 'Zazoobr' > Ignatiev" writes: > > > > > >Hello, > > I wrote geom class that handles SUN solaris/x86 disklabels, and > > want someone to review it... > > Attached is a gzipped patch. > > Sinceherely yours, Artem 'Zazoobr' Ignatjev. > > [...] > > Second, your contributed code has what looks like a rather carefree > attitude to copyright messages: > > +/* > + * This file was imported by timon@memphis.mephi.ru > + * Some fixes were made to compile under FreeBSD > + * Original copyright below. > + * Original filename was sys/dklabel.h > + * Copyright (c) 2003 by Artem Ignatiev > + */ > +/* > + * Copyright (c) 1990-1998 by Sun Microsystems, Inc. > + * All rights reserved. > + */ > + Poul-Henning is exactly right, we certainly won't be accepting any such code without some indication that Sun executives have allowed it. We can't possibly expect others to respect our copyrights if we blatantly ignore theirs. -- "Where am I, and what am I doing in this handbasket?" Wes Peters wes@softweyr.com