From owner-freebsd-current@FreeBSD.ORG Mon Jul 28 22:11:36 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 402AA37B401 for ; Mon, 28 Jul 2003 22:11:36 -0700 (PDT) Received: from mail.cyberonic.com (mail.cyberonic.com [4.17.179.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DCFD43F75 for ; Mon, 28 Jul 2003 22:11:35 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (node-40244c0a.sfo.onnet.us.uu.net [64.36.76.10]) by mail.cyberonic.com (8.12.8/8.12.5) with ESMTP id h6T5hS0n023533 for ; Tue, 29 Jul 2003 01:43:29 -0400 Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.9/8.11.6) id h6T5BXgV014957 for current@FreeBSD.org; Mon, 28 Jul 2003 22:11:33 -0700 (PDT) (envelope-from jmg) Date: Mon, 28 Jul 2003 22:11:33 -0700 From: John-Mark Gurney To: current@FreeBSD.org Message-ID: <20030729051133.GV10708@funkthat.com> Mail-Followup-To: current@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Subject: fixed another leak in USB code X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2003 05:11:36 -0000 Ok, those of you coming with panics due to kmem exhaustion w/ USB, I have fixed another leak. For some reason I assumed that big blocks were being deallocated upon free, not being put back on the freelist. (Have I mentioned how much it sucks that the USB code it self has five different allocators?) As mentioned in the commit message, I did some testing, and a simple bulk transfer over aue did not increase the devbuf memory usage, while before this patch, I got it quickly over 20megs and growing. Sorry for the breakage. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."