From owner-freebsd-current@FreeBSD.ORG Wed Feb 22 01:44:09 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 219EB16A420 for ; Wed, 22 Feb 2006 01:44:09 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.FreeBSD.org (Postfix) with SMTP id 557AE43D46 for ; Wed, 22 Feb 2006 01:44:07 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 2279 invoked by uid 399); 22 Feb 2006 01:44:06 -0000 Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 22 Feb 2006 01:44:06 -0000 Message-ID: <43FBC1E4.7020204@FreeBSD.org> Date: Tue, 21 Feb 2006 17:44:04 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20060112) MIME-Version: 1.0 To: Doug Barton , Divacky Roman , freebsd-current@freebsd.org References: <1140187193.731.47.camel@spirit> <20060217181842.GA21033@odin.ac.hmc.edu> <43F65A70.7080608@FreeBSD.org> <20060217234118.GA22643@odin.ac.hmc.edu> <43F67121.5080809@FreeBSD.org> <43F682F2.1020804@FreeBSD.org> <43F68611.7080602@FreeBSD.org> <20060219110732.GA12550@stud.fit.vutbr.cz> <43F8ABC8.30005@FreeBSD.org> <20060221180440.GB2996@galgenberg.net> In-Reply-To: <20060221180440.GB2996@galgenberg.net> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: Bad code in rcorder(8) (Was: Re: New RCorder: abi loaded too late) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2006 01:44:09 -0000 Ulrich Spoerlein wrote: >> Divacky Roman wrote: >>> I tried running rcorder under valgrind and it showed me massive >>> leaks/double-frees etc. unfortunately I am not able to run valgrind on recent >>> 7-current (when I start it it just creates 2.8G coredump) > Looks fine to me ... I think the trick is to repeat your test with some bad stuff in the scripts. So, create some circular dependencies, and some other impossible conditions, then repeat the test. Also, Divacky posted a PR with a start to cleaning up the code, might be worth some before and after on that. http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/93630 Doug -- This .signature sanitized for your protection