Date: Wed, 29 May 2019 21:19:45 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238223] Kernel fails to build: random_infra.c control reaches end of non-void function Message-ID: <bug-238223-227-57amhzWFaz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238223-227@https.bugs.freebsd.org/bugzilla/> References: <bug-238223-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238223 Conrad Meyer <cem@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress CC| |markm@FreeBSD.org Assignee|bugs@FreeBSD.org |cem@freebsd.org --- Comment #1 from Conrad Meyer <cem@freebsd.org> --- Weird, I guess you're using RANDOM_LOADABLE? The implementation is trivial= ly broken (my fault) in r346282. Fix is: --- a/sys/dev/random/random_infra.c +++ b/sys/dev/random/random_infra.c @@ -198,9 +198,12 @@ read_random(void *buf, u_int len) bool is_random_seeded(void) { + bool result; + RANDOM_CONFIG_S_LOCK(); - random_reader_context.is_random_seeded(); + result =3D random_reader_context.is_random_seeded(); RANDOM_CONFIG_S_UNLOCK(); + return (result); } --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238223-227-57amhzWFaz>