From owner-freebsd-bugs@freebsd.org Wed Oct 21 16:58:36 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E6A7A1B37A for ; Wed, 21 Oct 2015 16:58:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 617B3816 for ; Wed, 21 Oct 2015 16:58:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t9LGwaVw081130 for ; Wed, 21 Oct 2015 16:58:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203937] makefs: Coverity CID 975347, 975348: No provisions for i/o error Date: Wed, 21 Oct 2015 16:58:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: scdbackup@gmx.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 16:58:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203937 Bug ID: 203937 Summary: makefs: Coverity CID 975347, 975348: No provisions for i/o error Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/cd9660_eltorito.c CID 975347 : Unchecked return value from library (CHECKED_RETURN) 5. check_return: Calling fseek(fd, 32UL - strlen(part_type) - 1UL, 1) without checking return value. 575 fseek(fd, 32 - strlen(part_type) - 1, SEEK_CUR); CID 975348: Unchecked return value from library (CHECKED_RETURN) 33. check_return: Calling fseek(fd, 510L, 0) without checking return 639 fseek(fd, 0x1fe, SEEK_SET); (Ouch, an ISO producer which does not work on sequential file objects. That's quite inconvenient for users.) --------------- Source analysis: There are three fseek() with unchecked result: In cd9660_write_apm_partition_entry(): 573 fseek(fd, 32 - strlen(part_name) - 1, SEEK_CUR); 575 fseek(fd, 32 - strlen(part_type) - 1, SEEK_CUR); In cd9660_write_boot(): 639 fseek(fd, 0x1fe, SEEK_SET); Failed fseeko() is handled by calling err(), which exits the process: 554 if (fseeko(fd, (off_t)(idx + 1) * sector_size, SEEK_SET) == -1) 555 err(1, "fseeko"); --------------- Remedy proposal: Bail out by err(), too: - fseek(fd, 32 - strlen(part_name) - 1, SEEK_CUR); + if (fseek(fd, 32 - strlen(part_name) - 1, SEEK_CUR) == -1) + err(1, "fseek for APM partition"); - fseek(fd, 32 - strlen(part_type) - 1, SEEK_CUR); + if (fseek(fd, 32 - strlen(part_type) - 1, SEEK_CUR) == -1) + err(1, "fseek for APM partition"); - fseek(fd, 0x1fe, SEEK_SET); + if (fseek(fd, 0x1fe, SEEK_SET) == -1) + err(1, "fseek for MBR partition"); -- You are receiving this mail because: You are the assignee for the bug.