From owner-cvs-all@FreeBSD.ORG Mon Mar 3 09:05:12 2008 Return-Path: Delivered-To: cvs-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0394B1065670; Mon, 3 Mar 2008 09:05:12 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EBB5F8FC15; Mon, 3 Mar 2008 09:05:11 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from apple.my.domain (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m239571C011964; Mon, 3 Mar 2008 09:05:08 GMT (envelope-from davidxu@freebsd.org) Message-ID: <47CBBF91.3020404@freebsd.org> Date: Mon, 03 Mar 2008 17:06:25 +0800 From: David Xu User-Agent: Thunderbird 2.0.0.9 (X11/20071211) MIME-Version: 1.0 To: Jeff Roberson References: <200803020739.m227dNLe039427@repoman.freebsd.org> <47CBBE21.4060104@freebsd.org> In-Reply-To: <47CBBE21.4060104@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/kern init_main.c kern_cpuset.c kern_thread.c syscalls.master src/sys/sys _types.h cpuset.h proc.h types.h src/lib/libc/sys Symbol.map X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2008 09:05:12 -0000 David Xu wrote: > The cpuset_setaffinity with command CPU_WHICH_TID may hurt another > process if a weird process is out of the control. > The current code intents to lookup globally a thread has exact thread > id, because thread may be created and exited quickly, and thread ID is > reused quickly too, it is possible the weird process gives an outdated > thread ID to the API, and an irrelvant thread within another process > belongs to same user gets bind to cpus, such problem is very difficult > to be diagnosed when it happens, and it is an administrator is > nightmare. I think there should be a CPU_WHICH_TID_LOCAL command > to limit the searching scope in current process, and in most case, > the CPU_WHICH_TID_LOCAL will be used instead. > > Regards, > David Xu > > or we always pass pid to cpu_setaffinity.