Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Mar 2020 17:25:57 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r359273 - head/sys/net
Message-ID:  <202003241725.02OHPvPi073495@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Tue Mar 24 17:25:56 2020
New Revision: 359273
URL: https://svnweb.freebsd.org/changeset/base/359273

Log:
  iflib: split compound assertion
  
  ThunderX cluster systems are panicking on boot with a failed assertion
  MPASS(gtask != NULL && gtask->gt_taskqueue != NULL).  Split the
  assertion so that it's clear which part is failing.

Modified:
  head/sys/net/iflib.c

Modified: head/sys/net/iflib.c
==============================================================================
--- head/sys/net/iflib.c	Tue Mar 24 17:16:52 2020	(r359272)
+++ head/sys/net/iflib.c	Tue Mar 24 17:25:56 2020	(r359273)
@@ -6197,7 +6197,8 @@ iflib_admin_intr_deferred(if_ctx_t ctx)
 	struct grouptask *gtask;
 
 	gtask = &ctx->ifc_admin_task;
-	MPASS(gtask != NULL && gtask->gt_taskqueue != NULL);
+	MPASS(gtask != NULL);
+	MPASS(gtask->gt_taskqueue != NULL);
 #endif
 
 	GROUPTASK_ENQUEUE(&ctx->ifc_admin_task);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003241725.02OHPvPi073495>