From owner-freebsd-ports Thu Aug 12 16: 9:36 1999 Delivered-To: freebsd-ports@freebsd.org Received: from smtp11.bellglobal.com (smtp11.bellglobal.com [204.101.251.53]) by hub.freebsd.org (Postfix) with ESMTP id 166EA14D8F for ; Thu, 12 Aug 1999 16:09:31 -0700 (PDT) (envelope-from vanderh@ecf.toronto.edu) Received: from localhost.nowhere (ppp18343.on.bellglobal.com [206.172.130.23]) by smtp11.bellglobal.com (8.8.5/8.8.5) with ESMTP id TAA25095; Thu, 12 Aug 1999 19:11:30 -0400 (EDT) Received: (from tim@localhost) by localhost.nowhere (8.9.3/8.9.1) id TAA47413; Thu, 12 Aug 1999 19:10:02 -0400 (EDT) (envelope-from tim) Date: Thu, 12 Aug 1999 19:10:02 -0400 From: Tim Vanderhoek To: Anton Berezin Cc: Bill Fumerola , freebsd-ports@FreeBSD.ORG Subject: Re: ports/13030: Many ports use ``chown'' rather than ``/usr/sbin/chown'' in their Makefiles Message-ID: <19990812191002.C47301@mad> Reply-To: hoek@FreeBSD.ORG References: <19990809083649.B97354@mad> <19990812125750.B56987@lion.plab.ku.dk> <19990812093835.A44972@mad> <19990812160501.B57548@lion.plab.ku.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95i In-Reply-To: <19990812160501.B57548@lion.plab.ku.dk>; from Anton Berezin on Thu, Aug 12, 1999 at 04:05:01PM +0200 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Thu, Aug 12, 1999 at 04:05:01PM +0200, Anton Berezin wrote: > > > > # skip clever CHOWN assignments - they are unnecessary > > > next if m%^\s*CHOWN\s*\??=\s*(?:/usr/sbin/)?chown\s*$%; I mean it should just issue a short warning. I assume the number of these lines is small enough that whoever reads the warning can just remove the lines themself. > > > s%/usr/sbin/chown%\${CHOWN}%g; > > > > Better add \s+ to the start of that, just to be safe. Shouldn't make > > No! Consider @/usr/sbin/chown - there are plenty of these. You're right. You could try [\s@] (is that legal? I don't think so, but I mean it's legal equivalent... :). Or your suggestion, slightly modified, [^}$/]. It's quite likely not worth worrying about too much. -- This is my .signature which gets appended to the end of my messages. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message