Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Aug 1999 19:10:02 -0400
From:      Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To:        Anton Berezin <tobez@plab.ku.dk>
Cc:        Bill Fumerola <billf@jade.chc-chimes.com>, freebsd-ports@FreeBSD.ORG
Subject:   Re: ports/13030: Many ports use ``chown'' rather than ``/usr/sbin/chown'' in their Makefiles
Message-ID:  <19990812191002.C47301@mad>
In-Reply-To: <19990812160501.B57548@lion.plab.ku.dk>; from Anton Berezin on Thu, Aug 12, 1999 at 04:05:01PM %2B0200
References:  <19990809083649.B97354@mad> <Pine.BSF.4.10.9908090901570.72927-100000@jade.chc-chimes.com> <19990812125750.B56987@lion.plab.ku.dk> <19990812093835.A44972@mad> <19990812160501.B57548@lion.plab.ku.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 12, 1999 at 04:05:01PM +0200, Anton Berezin wrote:
> 
> > >       # skip clever CHOWN assignments - they are unnecessary
> > >       next if m%^\s*CHOWN\s*\??=\s*(?:/usr/sbin/)?chown\s*$%;

I mean it should just issue a short warning.  I assume the number of
these lines is small enough that whoever reads the warning can just
remove the lines themself.


> > >       s%/usr/sbin/chown%\${CHOWN}%g;
> > 
> > Better add \s+ to the start of that, just to be safe.  Shouldn't make
> 
> No!  Consider @/usr/sbin/chown - there are plenty of these.

You're right.  You could try [\s@] (is that legal?  I don't think so,
but I mean it's legal equivalent...  :).  Or your suggestion,
slightly modified, [^}$/].

It's quite likely not worth worrying about too much.


-- 
This is my .signature which gets appended to the end of my messages.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990812191002.C47301>