From owner-freebsd-gecko@freebsd.org Tue Aug 8 06:00:28 2017 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2802DC4112 for ; Tue, 8 Aug 2017 06:00:28 +0000 (UTC) (envelope-from francois@mozilla.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9D4CF70B80 for ; Tue, 8 Aug 2017 06:00:28 +0000 (UTC) (envelope-from francois@mozilla.com) Received: by mailman.ysv.freebsd.org (Postfix) id 99BFFDC4111; Tue, 8 Aug 2017 06:00:28 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9952DDC410F for ; Tue, 8 Aug 2017 06:00:28 +0000 (UTC) (envelope-from francois@mozilla.com) Received: from mail-pg0-x22c.google.com (mail-pg0-x22c.google.com [IPv6:2607:f8b0:400e:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6946270B7E for ; Tue, 8 Aug 2017 06:00:28 +0000 (UTC) (envelope-from francois@mozilla.com) Received: by mail-pg0-x22c.google.com with SMTP id v77so10678560pgb.3 for ; Mon, 07 Aug 2017 23:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mozilla.com; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M3G4RTcewka1pY6N8dodz9c5TmkRi8gjCmHWD28J35A=; b=SpvzWLySQJ+VwV3YflVDu63BOwO+w2yNyNzg5c2dpCQ8qjFQX/CtOnOQLfJquQewAN MdZ+mUIlt1aFeo67h0UxnG8hcH/4R1mEI0SZLN6UowJbG79neWR/5GMt4VzJKXIyErKn YvObraxIULfLcr6Txrm1duL1vnKuaAbZDEk7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M3G4RTcewka1pY6N8dodz9c5TmkRi8gjCmHWD28J35A=; b=Unsm55nA9ndgEG0BbRDkEwVm0S8u92Zfkf7bmyQca6+n4Zexe6/E7oeYPwjrx4IXS2 9CE3iA9JxbobhN9R6HCDXPljbxXzVH6zGK7KrJsex9tRYX35aKkaMIrv42qudO+FkZmB nNEt98FtLCP1E9UqUH9WlxGAvffGBFdsd0br1chhFO+3y3WiKn0Wd00O8WdqUlQwVnlU 4reJUpm8MqCrWg2L1vq6zo9/f2ym27EiFIzGLkeg8YicvDWxpwJd4fYp19tRu9eh9/gp NN/KzehlFWq4RCpBtDe/n70100u9vp8F0Gt1HLwe2Ucq+jqsI5pVO4zvkPToGFCRzgxR N8Cw== X-Gm-Message-State: AHYfb5iH0lePXTWJ8Dty1bus7+mgcmt3Rz9Ao6RA+Mc1S4OEHhwb1530 +ceq3Dq+fiS/wnl3stGa2Q== X-Received: by 10.98.236.78 with SMTP id k75mr3185189pfh.215.1502172027680; Mon, 07 Aug 2017 23:00:27 -0700 (PDT) Received: from [192.168.1.208] (216-71-194-197.dyn.novuscom.net. [216.71.194.197]) by smtp.googlemail.com with ESMTPSA id k3sm839347pgf.33.2017.08.07.23.00.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Aug 2017 23:00:27 -0700 (PDT) Subject: Re: Firefox 56 in FreeBSD: Safe Browsing API key required To: Jan Beich Cc: gecko@FreeBSD.org, =?UTF-8?Q?Ren=c3=a9_Ladan?= References: <7a098f0b-2412-5ea5-5378-eb36c68fee2a@mozilla.com> From: Francois Marier Openpgp: url=https://people.mozilla.org/~fmarier/francois_marier.asc Message-ID: Date: Mon, 7 Aug 2017 23:00:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2017 06:00:28 -0000 On 07/08/17 09:37 PM, Jan Beich wrote: > Do you mean "google" or "google4" in about:url-classifier? Both seem to > be available in FF55 and FF56. However, "google4" currently fails as > "cannot update" or "download error (400)" e.g., "google4" is the new version of Safe Browsing. That 400 you are seeing is what happens when there is no valid API key. Note that while "google" is still available today, it won't be forever. Google is planning to turn off the old servers next year. > The patch is just a workaround to avoid having to generate a temporary file. > The API key is in another file, see > > https://svnweb.freebsd.org/ports/head/Mk/bsd.gecko.mk?view=markup#l276 Ah I see. Thanks. >> If you are indeed already including a Google API key in your builds, >> then all you need to do is to add the Safe Browsing API to it, see >> https://bugzilla.mozilla.org/show_bug.cgi?id=1377987#c0. > > Does SafeBrowsing require defining MOZILLA_OFFICIAL during build which > would also enable Telemetry pings? It doesn't. If the API key is present, it should just work. If it doesn't, that's a bug. >> Afterwards, if you send me the project ID (not the API key), I can >> liaise with Google to make sure it has the right access and appropriate >> quota. > > Our gecko@ team shares Google API key with chromium@ team. rene@ was the > one who originally obtained the key, so maybe he still has the project ID. It should be visible somewhere on https://console.developers.google.com/. Francois