From owner-cvs-all Wed Mar 3 20:59:33 1999 Delivered-To: cvs-all@freebsd.org Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (Postfix) with SMTP id 4416314BFD; Wed, 3 Mar 1999 20:59:29 -0800 (PST) (envelope-from luigi@labinfo.iet.unipi.it) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id DAA08763; Thu, 4 Mar 1999 03:51:42 +0100 From: Luigi Rizzo Message-Id: <199903040251.DAA08763@labinfo.iet.unipi.it> Subject: Re: cvs commit: src/sys/netinet if_ether.c To: wpaul@FreeBSD.ORG (Bill Paul), luigi@labinfo.iet.unipi.it (Luigi Rizzo) Date: Thu, 4 Mar 1999 03:51:41 +0100 (MET) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG In-Reply-To: <199903040403.UAA14424@freefall.freebsd.org> from "Bill Paul" at Mar 3, 99 08:03:38 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1170 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > Modified files: > sys/netinet if_ether.c > Log: > arprequest() allocates an mbuf with m_gethdr() but does not initialize > m->m_pkthdr.rcvif to NULL. Bad arprequest(). No biscuit. does this have any unwanted side effect on the lower layers ? (i can see one place in bdg_forward() but fortunately this is not too terrible for the normal case...) i ask because the whole mbuf header is generally left uninitialized (burned myself with this with the previous dummynet implementation) so the code should not make too many assumption on some fields (e.g. one might think that rcvif is not meaningful in the output path and should not be used there. of course your change goes in the sense of a more robust implementation and it is greatly welcome. cheers luigi -----------------------------------+------------------------------------- Luigi RIZZO . EMAIL: luigi@iet.unipi.it . Dip. di Ing. dell'Informazione HTTP://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message