Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Feb 2015 00:19:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 196185] emulators/hyperv-is: Update Hyper-V ports for FreeBSD 10.1
Message-ID:  <bug-196185-13-gQjVQoDleI@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-196185-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-196185-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #11 from Xin LI <delphij@FreeBSD.org> ---
@FangJun -- There are a few issues with the patch ("patch (35.41 KB, patch) 
2014-12-23 05:36 UTC").  Could you please check?

1) src/sys/dev/hyperv/utilities/hv_util.c: in tree driver should never return
BUS_PROBE_VENDOR.  Otherwise vendor supplied driver will not take precedence.

I would recommend making a (git or your source code management tool) branch for
in-tree driver submission to make it easier for future merge, etc., as the SCM
tool would take care for this kind of differences.

2) same file -- the driver name have been changed from "hyperv-utils" to
"hyperv-utils-port", is this intentional? (I think it's not but it's ok if it's
intentional).

3) hyperv_support.S is missing in the patch.  Please use use '-N' when
generating the diff.

I can make minor corrections manually.  If the changes would be larger please
generate a new diff.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196185-13-gQjVQoDleI>