From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Feb  3 00:19:07 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 74CD466D
 for <freebsd-ports-bugs@FreeBSD.org>; Tue,  3 Feb 2015 00:19:07 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5B222B96
 for <freebsd-ports-bugs@FreeBSD.org>; Tue,  3 Feb 2015 00:19:07 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t130J7Rh014568
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 3 Feb 2015 00:19:07 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 196185] emulators/hyperv-is: Update Hyper-V ports for FreeBSD
 10.1
Date: Tue, 03 Feb 2015 00:19:07 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: needs-patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: delphij@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback+
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-196185-13-gQjVQoDleI@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-196185-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-196185-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2015 00:19:07 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #11 from Xin LI <delphij@FreeBSD.org> ---
@FangJun -- There are a few issues with the patch ("patch (35.41 KB, patch) 
2014-12-23 05:36 UTC").  Could you please check?

1) src/sys/dev/hyperv/utilities/hv_util.c: in tree driver should never return
BUS_PROBE_VENDOR.  Otherwise vendor supplied driver will not take precedence.

I would recommend making a (git or your source code management tool) branch for
in-tree driver submission to make it easier for future merge, etc., as the SCM
tool would take care for this kind of differences.

2) same file -- the driver name have been changed from "hyperv-utils" to
"hyperv-utils-port", is this intentional? (I think it's not but it's ok if it's
intentional).

3) hyperv_support.S is missing in the patch.  Please use use '-N' when
generating the diff.

I can make minor corrections manually.  If the changes would be larger please
generate a new diff.

-- 
You are receiving this mail because:
You are the assignee for the bug.