From owner-freebsd-bugs@freebsd.org Tue Jan 28 21:58:13 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7176F242A11 for ; Tue, 28 Jan 2020 21:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486gTx2VD4z3Cxs for ; Tue, 28 Jan 2020 21:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 55889242A10; Tue, 28 Jan 2020 21:58:13 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 554E9242A0F for ; Tue, 28 Jan 2020 21:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486gTx1TtYz3Cxr for ; Tue, 28 Jan 2020 21:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2E6281BEC for ; Tue, 28 Jan 2020 21:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SLwDBx085036 for ; Tue, 28 Jan 2020 21:58:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SLwDtt085035 for bugs@FreeBSD.org; Tue, 28 Jan 2020 21:58:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 243683] Need to add quirk for Micron 5300 series of ssd drives Date: Tue, 28 Jan 2020 21:58:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: satan@Ukr.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 21:58:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243683 Bug ID: 243683 Summary: Need to add quirk for Micron 5300 series of ssd drives Product: Base System Version: 12.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: satan@Ukr.net Created attachment 211142 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D211142&action= =3Dedit Adding quirk to disable UNMAP/TRIM for Micron 5300 SSD Quirks for a Micron 5300 pro sata ssd drive. When truing to use it in zfs pool find terrible performance caused by zfs sending trim command to ssd. For example samsung PM863a worked in same pool have x 10 better performance. After disable trim via quirks for micron get= =20 performance near or beatter then PM863a. So looks like Micron have troble w= ith=20 trim/unmap on that type of devices. In attachment I place quick patch adding quirks to scsi_da.c and ata_da.c=20 where simply adding quirk for 4k (looks like no needed ) and DA_Q_NO_UNMAP/ADA_Q_NO_TRIM for that's device's. quirks tested on 12.1-STABLE and 11.2-STABLE=20=20 On 11.2 only for for scsi_da.c as quirk ADA_Q_NO_TRIM doesn't exist. Its will be good if some body can confirm that fix is right and push change= s to upstream=20 Patch again 12.1-STABLE FreeBSD 12.1-STABLE r357144 --=20 You are receiving this mail because: You are the assignee for the bug.=