Date: 19 May 2003 10:06:45 +0200 From: Kay Lehmann <kay_lehmann@web.de> To: Tilman Linneweh <arved@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/52129: New port: sysutils/lineakd: Lineakd is a daemon which enables special keys on internet keyboards. Message-ID: <1053331605.583.8.camel@bippes.wg-berlin.de> In-Reply-To: <200305141456.h4EEuEPu026869@freefall.freebsd.org> References: <200305141456.h4EEuEPu026869@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-pKN/wvYCf6MzI9RNHVYP
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Am Mi, 2003-05-14 um 16.56 schrieb Tilman Linneweh:
> Synopsis: New port: sysutils/lineakd: Lineakd is a daemon which enables special keys on internet keyboards.
>
> State-Changed-From-To: open->feedback
> State-Changed-By: arved
> State-Changed-When: Wed May 14 07:50:47 PDT 2003
> State-Changed-Why:
> Several Issues:
>
> - Don't use expanded $FreeBSD$ Ids in new ports.
> - USE_BISON instead of BUILD_DEPENDS on bison
> - gettext is already at library version 4
> - use ${X11BASE} instead of hardcoding /usr/x11R6
> - tabs not spaces.
> - Additional Documentation should go into ${PREFIX}/share/doc/${PORTNAME}
> also consider supoorting the PORTDOCS variable
> - most important: patch-bb does not apply
>
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=52129
Fix most of the problems listed.
Greetings,
Kay
--
Kay Lehmann <kay_lehmann@web.de>
--=-pKN/wvYCf6MzI9RNHVYP
Content-Disposition: attachment; filename=lineakd.diff
Content-Type: text/plain; name=lineakd.diff; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
--- lineakd.shar_1 Tue May 13 11:08:28 2003
+++ lineakd.shar Mon May 19 09:55:58 2003
@@ -10,6 +10,8 @@
# lineakd/files/patch-aa
# lineakd/files/patch-bb
# lineakd/files/patch-cc
+# lineakd/files/patch-dd
+# lineakd/files/patch-ee
# lineakd/Makefile
# lineakd/pkg-plist
# lineakd/pkg-descr
@@ -127,13 +129,58 @@
X #if defined HAVE_UNISTD_H || defined _LIBC
X # include <unistd.h>
END-of-lineakd/files/patch-cc
+echo x - lineakd/files/patch-dd
+sed 's/^X//' >lineakd/files/patch-dd << 'END-of-lineakd/files/patch-dd'
+X--- Makefile.in.orig Thu May 15 16:05:33 2003
+X+++ Makefile.in Thu May 15 16:06:13 2003
+X@@ -112,7 +112,7 @@
+X
+X SUBDIRS = intl po src
+X
+X-lineakddocdir = ${prefix}/doc/lineakd
+X+lineakddocdir = ${prefix}/share/doc/lineakd
+X lineakddoc_DATA = \
+X README\
+X COPYING\
+END-of-lineakd/files/patch-dd
+echo x - lineakd/files/patch-ee
+sed 's/^X//' >lineakd/files/patch-ee << 'END-of-lineakd/files/patch-ee'
+X--- Makefile.orig Thu May 15 16:09:02 2003
+X+++ Makefile Thu May 15 16:10:10 2003
+X@@ -83,14 +83,14 @@
+X LTLIBINTL =
+X MKINSTALLDIRS = ./mkinstalldirs
+X NO_PREFIX_PACKAGE_DATA_DIR = share/lineakd
+X-NO_PREFIX_PACKAGE_DOC_DIR = doc/lineakd
+X+NO_PREFIX_PACKAGE_DOC_DIR = share/doc/lineakd
+X NO_PREFIX_PACKAGE_HELP_DIR = share/lineakd/help
+X NO_PREFIX_PACKAGE_MENU_DIR = share/lineakd
+X NO_PREFIX_PACKAGE_PIXMAPS_DIR = share/lineakd/pixmaps
+X OBJEXT = o
+X PACKAGE = lineakd
+X PACKAGE_DATA_DIR = /usr/local/share/lineakd
+X-PACKAGE_DOC_DIR = /usr/local/doc/lineakd
+X+PACKAGE_DOC_DIR = /usr/local/share/doc/lineakd
+X PACKAGE_HELP_DIR = /usr/local/share/lineakd/help
+X PACKAGE_MENU_DIR = /usr/local/share/lineakd
+X PACKAGE_PIXMAPS_DIR = /usr/local/share/lineakd/pixmaps
+X@@ -112,7 +112,7 @@
+X
+X SUBDIRS = intl po src
+X
+X-lineakddocdir = ${prefix}/doc/lineakd
+X+lineakddocdir = ${prefix}/share/doc/lineakd
+X lineakddoc_DATA = \
+X README\
+X COPYING\
+END-of-lineakd/files/patch-ee
echo x - lineakd/Makefile
sed 's/^X//' >lineakd/Makefile << 'END-of-lineakd/Makefile'
X# New ports collection makefile for: lineakd
X# Date created: 03 June 2002
X# Whom: Kay Lehmann
X#
-X# $FreeBSD: ports/sysutils/lineakd/Makefile,v 1.1 2002/05/15 22:37:50 cy Exp $
+X# $FreeBSD$
X#
X
XPORTNAME= lineakd
@@ -146,14 +193,14 @@
XMAINTAINER= kay_lehmann@web.de
XCOMMENT= Lineakd is a daemon which enables special keys on internet keyboards.
X
-XBUILD_DEPENDS= bison:${PORTSDIR}/devel/bison
-XLIB_DEPENDS= intl.2:${PORTSDIR}/devel/gettext
+XLIB_DEPENDS= intl.4:${PORTSDIR}/devel/gettext
X
+XUSE_BISON= yes
XUSE_GMAKE= yes
XUSE_XLIB= yes
XGNU_CONFIGURE= yes
X
-XCFLAGS+= -I/usr/X11R6/include
+XCFLAGS+= -I${X11BASE}/include
X
X.include <bsd.port.mk>
END-of-lineakd/Makefile
@@ -163,17 +210,17 @@
Xetc/lineakkb.def
Xlib/charset.alias
Xshare/locale/locale.alias
-Xdoc/lineakd/README
-Xdoc/lineakd/COPYING
-Xdoc/lineakd/AUTHORS
-Xdoc/lineakd/ChangeLog
-Xdoc/lineakd/INSTALL
-Xdoc/lineakd/NEWS
-Xdoc/lineakd/TODO
-Xdoc/lineakd/ABOUT-NLS
+Xshare/doc/lineakd/README
+Xshare/doc/lineakd/COPYING
+Xshare/doc/lineakd/AUTHORS
+Xshare/doc/lineakd/ChangeLog
+Xshare/doc/lineakd/INSTALL
+Xshare/doc/lineakd/NEWS
+Xshare/doc/lineakd/TODO
+Xshare/doc/lineakd/ABOUT-NLS
X@dirrm share/locale
-X@dirrm doc/lineakd
-X@dirrm doc
+X@dirrm share/doc/lineakd
+X@dirrm share/doc
END-of-lineakd/pkg-plist
echo x - lineakd/pkg-descr
sed 's/^X//' >lineakd/pkg-descr << 'END-of-lineakd/pkg-descr'
--=-pKN/wvYCf6MzI9RNHVYP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1053331605.583.8.camel>