From nobody Tue Apr 19 17:24:58 2022 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 08B3911CF43A for ; Tue, 19 Apr 2022 17:24:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KjVzt3m0sz3qYj for ; Tue, 19 Apr 2022 17:24:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5D7FD2BA0F for ; Tue, 19 Apr 2022 17:24:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23JHOwbx081113 for ; Tue, 19 Apr 2022 17:24:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23JHOwUN081112 for net@FreeBSD.org; Tue, 19 Apr 2022 17:24:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 263379] [regression] [ipsec] compatibility broken between stable/12 and stable/13 opencrypto in AEAD mode Date: Tue, 19 Apr 2022 17:24:58 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650389098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Un+P2QSfme/KM6kDTXSox4iioEgI5sxd04uen5Q4/7g=; b=A0h7P6D0m00TDf+uquP8a30svP44CrOiAgENYfOw5Og/eldAbB+8cB/MnqshLAUTuKvOtB xLmbHCBJWHRZtNh1QF8HWUZZqNnqCcUCh0LinHgyYMNFs5EmMymrcYbRvYjTXk+1/+0wRk zVAD6ObQFH6hE+DMePZyZXf8ICAhFARQLQ0EYSvyhtY3Jmbd8410NjIvz07tju+fUYNHNg 3v03Qget99mbsaHGxjxc+SQEBJuLzBhu0qAOwBQKoVe3UhONaOEaMEIWDmEdzd/vHz5hr5 Q1J9FfAsCT2zeRBF4YzxnTOFKH5kFqVNnqC0u1ROMv4wYLI6RQvzV4Il2B0hhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650389098; a=rsa-sha256; cv=none; b=bt0Ib0wpq+zUzfZQ2ACgw+wfotCHCYmYACKsfgvW9sTifaXb6bI+Ju9zw3dZINI5NmEwLt YEXTql+nuAi2Bo0+i0hoDZR5NyDEViYeynnXowa76UP8yW2db37O0ltYDmLO+ocAfRGQRH GZoNWSLO4TPqejhzI88eb1pBKE2ysnlOCI924m0W/q0mmxHGxVcoGCxJ83ZT/QF5sL1IGC cCvTYXIEdsYUwkNFEs2LWAti2bWJdgZQQdc+b3Ns2NHSAIZBZpoFH0jIzXjymaV68ixpfv VM0jCEAEaxeY6rD1rjRJNpHGFSMFCUyOk7IhDEQpgr7LZ97R0ZHeJaEGTPzEfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263379 --- Comment #11 from Eugene Grosbein --- (In reply to John Baldwin from comment #10) Thank you very much. I've found that EINVAL is also returned if I forget to kldload ipsec.ko. Pilot error. OTOH, maybe it is time for our setkey(8) to kldload ipsec.ko automatically = just like ifconfig(8) loads needed modules. We have ipsec.ko in all supported branches (since 11.1-RELEASE). Something like this maybe? --- sbin/setkey.c.orig 2022-02-04 20:36:27.627040000 +0000 +++ sbin/setkey.c 2022-04-19 17:22:46.193421000 +0000 @@ -34,6 +34,8 @@ #include #include +#include +#include #include #include #include @@ -102,6 +104,17 @@ usage() exit(1); } +static int +modload(const char *name) +{ + if (modfind(name) < 0) + if (kldload(name) < 0 || modfind(name) < 0) { + warn("%s: module not found", name); + return 0; + } + return 1; +} + int main(ac, av) int ac; @@ -167,6 +180,7 @@ main(ac, av) } } + modload("ipsec"); so =3D pfkey_open(); if (so < 0) { perror("pfkey_open"); --=20 You are receiving this mail because: You are on the CC list for the bug.=