From owner-cvs-src@FreeBSD.ORG Wed Dec 21 09:16:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74A8416A420; Wed, 21 Dec 2005 09:16:43 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5209B43D92; Wed, 21 Dec 2005 09:16:27 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jBL9GQFA006634; Wed, 21 Dec 2005 11:16:26 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 64998-03-3; Wed, 21 Dec 2005 11:16:25 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jBL9FTCt006584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 21 Dec 2005 11:15:29 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id jBL9FcIN055588; Wed, 21 Dec 2005 11:15:38 +0200 (EET) (envelope-from ru) Date: Wed, 21 Dec 2005 11:15:38 +0200 From: Ruslan Ermilov To: Doug Barton Message-ID: <20051221091538.GC55142@ip.net.ua> References: <200512202056.jBKKuLQO034591@repoman.freebsd.org> <20051221080846.GA55142@ip.net.ua> <43A91330.2000704@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8X7/QrJGcKSMr1RN" Content-Disposition: inline In-Reply-To: <43A91330.2000704@FreeBSD.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2005 09:16:43 -0000 --8X7/QrJGcKSMr1RN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2005 at 12:32:48AM -0800, Doug Barton wrote: > Ruslan Ermilov wrote: > >On Tue, Dec 20, 2005 at 08:56:21PM +0000, Doug Barton wrote: > >>dougb 2005-12-20 20:56:21 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: (Branch: RELENG_6) > >> etc/rc.d Makefile=20 > >> Log: > >> MFC 1.56, make install of sshd conditional on NO_OPENSSH > >> =20 > >> Revision Changes Path > >> 1.53.2.4 +6 -1 src/etc/rc.d/Makefile > >> > >The full condition, to match the sources, would be: > > > >.if !defined(NO_CRYPT) && !defined(NO_OPENSSL) && !defined(NO_OPENSSH) > > > >That's how we get to compile secure/usr.sbin/sshd/. >=20 > Well, I wondered about that, but I didn't make the original change, so I= =20 > just MFC'ed what was there. If you want to update the Makefile in HEAD I'= ve=20 > no objection, or if you think it's really important, I'll be glad to do i= t=20 > as well. >=20 Please do it while you're at it. > Personally, while I remember the support problems that not having all tho= se=20 > tests caused back in the day, I always thought that it was providing too= =20 > big a crutch. However, that's just grousing, and I've no objection to=20 > updating rc.d/Makefile if you think we need to. >=20 Well, if the installation is conditional, the condition should be correct. Otherwise, it should be made unconditional. :-) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --8X7/QrJGcKSMr1RN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDqR06qRfpzJluFF4RAhZhAJoD4YODiSPeVq/O9Ap+UNGNvskFQQCfUCBB xupjBOIo5MaYAG3VI7uwYds= =o1uf -----END PGP SIGNATURE----- --8X7/QrJGcKSMr1RN--