From nobody Tue Feb 17 19:42:20 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fFqmF56Xxz6Rxj6; Tue, 17 Feb 2026 19:42:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fFqmF4Sj7z3dxP; Tue, 17 Feb 2026 19:42:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771357341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yeu4fzyuSLpImXuEm0jiYeN3cjRj0XH7sqJYA/tdL5c=; b=PQR7xv3lpEHiWr7BYE3ibaD7FKqvVwU6c7Zz2NiroJWJ/l6v2H/hyP4eAF15zJy2A19tdW gSomdNEpuU98xbYUCyGelInhq8GlJZ+ecyVPurqmlBkS/X6U+S9IKu1kcurBCCBusCpdx0 zKUYQ2TTSD4o5AEtCp/hbzfNLEwHa+8mdyfgXOOmsCQbO4TtekrZ3Z3h+STYGgn0mHHX2v e9Niy36eYI1KKPxrCqedfIJ4OrfxwTMJ0bzLWHG6apvBf5UPcIj0gvJzJ1PueZvZ3ieaTS wbRT1Uk7n5CVrtSPgk2bh1cfxgLIiXrmKHOQWlnQHJ8JaTHKUDBAgWxiacJaZg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771357341; a=rsa-sha256; cv=none; b=XwVQy1tFumgAKLRztCKtHFcAHsGelIlRwp4Ilt8cs5hr2NtCFEdHX8vHDU0JmJbqm4dEHq 34u5LNGqXSCvqK3U70/6aVUKQ16AzIU7nIANa0DMecJOS/W6LhXg2en9VLtg3e/eU7UIH2 /sHHpWGVHMfEvzrn8xLcyEQptgeboqkDhSwWRDgUv1y8pF/h4CMLKI81uwnRnxtpLKiJ/E 7yd62Q2tKfnY3vmoPXravwVGpmszPz2EKF+MAr9rzihpVds29dLCeEvAYbIjgv3HGgwrF2 mg/w8mfrC4FcVkOzy4b3nlI8fDsjUOblJQmZXe58JHDb30cnWSb4xCybbPuFcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771357341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yeu4fzyuSLpImXuEm0jiYeN3cjRj0XH7sqJYA/tdL5c=; b=aHBouHgy9pRJmqcqJoX1y6QrUg1TcbXWhGp4CpbwmeUROiP3boVLR8gbi1RR3gB1TC0ZPp ao2SrFT5wLxbbDkAaZyMmhI6nuk5p7+MyFcuORiUJZzu8uHVG0i9RicrcZIT2O0MpVcDhi oulNnAMiwQA4bvLoAjEtZ4aH9bHxbQ4tb2sUiyoN5JAw9SlOAqzPVwhiqYxku8JBrtyr0J L6O9mjjJeI4Q4BDX1tsDAXyWqXyc9xgZP1w2sTgZyV+lefiP9PuqzBdsmWKN0b/oULNbfC YusPj15SPjT2JAwSdPYFMOdtaKTibqL6t8Yb74Fu9gS5fqSR3BUvZjzA33HlMg== Received: from [IPV6:2601:5c0:4202:5670:475:8f88:8099:d67] (unknown [IPv6:2601:5c0:4202:5670:475:8f88:8099:d67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fFqmF2W9Gz8Yb; Tue, 17 Feb 2026 19:42:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <1d35e758-ff0d-4fb3-9a4c-a0fc69182d41@FreeBSD.org> Date: Tue, 17 Feb 2026 14:42:20 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 97ce8f7d2b8e - main - amd64: define and use STACKALIGN and REDZONE_SZ Content-Language: en-US To: Konstantin Belousov , "Enji Cooper (yaneurabeya)" Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <698a1ffe.26e3c.47182d66@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/16/26 21:44, Konstantin Belousov wrote: > On Mon, Feb 16, 2026 at 05:01:58PM -0800, Enji Cooper (yaneurabeya) wrote: >> >>> On Feb 9, 2026, at 9:57 AM, Konstantin Belousov wrote: >>> >>> The branch main has been updated by kib: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=97ce8f7d2b8eff42460f60e8c49d9849b58b6e81 >>> >>> commit 97ce8f7d2b8eff42460f60e8c49d9849b58b6e81 >>> Author: Konstantin Belousov >>> AuthorDate: 2026-02-07 00:36:44 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2026-02-09 17:57:00 +0000 >>> >>> amd64: define and use STACKALIGN and REDZONE_SZ >>> >>> Reviewed by: brooks, emaste, jhb >>> Sponsored by: The FreeBSD Foundation >>> MFC after: 1 week >>> Differential revision: https://reviews.freebsd.org/D55151 >> >> Hi kib@! >> It looks like this broke the build with gcc12 on main: https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/2893/console . > > https://reviews.freebsd.org/D55319 > might be the fix. I have the same thing at https://reviews.freebsd.org/D55161 Per my comments there, I do think it might break 32-bit kernels, but we probably don't care about that. (Namely, if rounddown2() is used on a type larger than uintptr_t such as trunc_page on a vm_paddr_t on i386, this change truncates the value). If we really care, we could use _Generic or the like to only use the uintptr_t casts for pointer types. -- John Baldwin