From owner-svn-src-all@freebsd.org Sat May 18 12:50:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 568F515B1F59; Sat, 18 May 2019 12:50:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 90CC080BC2; Sat, 18 May 2019 12:50:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x4ICnp0Q008809 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 18 May 2019 15:49:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x4ICnp0Q008809 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x4ICnnS5008808; Sat, 18 May 2019 15:49:49 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 18 May 2019 15:49:49 +0300 From: Konstantin Belousov To: Benedict Reuschling Cc: Bruce Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r347951 - stable/12/lib/libc/stdlib Message-ID: <20190518124949.GB2748@kib.kiev.ua> References: <201905180315.x4I3F8g2080553@repo.freebsd.org> <20190518082838.GW2748@kib.kiev.ua> <20190518210514.V913@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 May 2019 12:50:04 -0000 On Sat, May 18, 2019 at 08:39:03AM -0400, Benedict Reuschling wrote: > Hello Konstantin and Bruce, > > thank you for your comments. Clearly, this should have been addressed in > the review and checked by a second pair of eyes. I mostly did the man > page changes and can't comment much on the actual coding example. Two > people (dab and jilles) approved the revision in the Phabricator review. > There was plenty of time to review it between April 16 and May 15 when > then the original submitter asked if there was anything else that needs > to be done. > > Now, having said that and the the change is now both in HEAD and > stable/12, how do we proceed? Revert them both or patch those issues as > follow-ups? Note that a src committer should do that and not me trying > to add more EXAMPLE sections to man pages with my doc commit bit. > Try to improve it. I think there is some value in having a good and non-buggy example for the function(s), but we are not there yet. You have a lot of comments with direct actions.