From owner-freebsd-fs@FreeBSD.ORG Tue Nov 25 14:57:19 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 426801065670 for ; Tue, 25 Nov 2008 14:57:19 +0000 (UTC) (envelope-from josh.carroll@gmail.com) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.29]) by mx1.freebsd.org (Postfix) with ESMTP id E96648FC12 for ; Tue, 25 Nov 2008 14:57:18 +0000 (UTC) (envelope-from josh.carroll@gmail.com) Received: by yw-out-2324.google.com with SMTP id 9so1067350ywe.13 for ; Tue, 25 Nov 2008 06:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=RRS1FXdk6KlOebjY9FSAS8fA0kl0y8YlEbfplRT45M0=; b=Jdoquum9NTRB8Y0QWe5f8nVgLb8KfQcg0Nt6AoMr9acbSrXoHEhV7gYmJrymn+7uwW Sw9ypTcOTH1ZR8JZ6e55Ii8jZ36ytrGvHULsbe9aLoYkI+CEMwR5t5stql0dU8B492Q6 Npv9G8Qdzt/ok6XTJQxB8TWm2JSo1p3K/UARI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:references; b=lsYAyPaKcTCUAIp/Wj2A4i6S4P+wIouowlWywrqAgdKywOQ/brvAQrjy/fq6EoQdDz 0+iFAW/TN5PGzkneHzVWCxSrEm5dbniD/tsv/135HgwW9S1uLJiV5BRVrwvK4riSd8tU HkCGK/J+VNsfPKDfHslQVJytvu0VuUBTeJb5E= Received: by 10.150.49.15 with SMTP id w15mr8563645ybw.152.1227625038227; Tue, 25 Nov 2008 06:57:18 -0800 (PST) Received: by 10.150.218.5 with HTTP; Tue, 25 Nov 2008 06:57:18 -0800 (PST) Message-ID: <8cb6106e0811250657q6fdf08b0x1e94f35fd0a7ed4f@mail.gmail.com> Date: Tue, 25 Nov 2008 09:57:18 -0500 From: "Josh Carroll" To: "Kostik Belousov" In-Reply-To: <20081125142827.GI2042@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8cb6106e0811241129o642dcf28re4ae177c8ccbaa25@mail.gmail.com> <20081125140601.GH2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> <20081125142827.GI2042@deviant.kiev.zoral.com.ua> Cc: freebsd-fs@freebsd.org, FreeBSD Stable Subject: Re: ext2 inode size patch - RE: PR kern/124621 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: josh.carroll@gmail.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 14:57:19 -0000 > I do not suggest testing. I suggest understand what inode metadata is stored > in the added 128 bytes and evaluate whether this information can be ignored > without dangerous consequences for filesystem consistency or user data. > Well, to be clear I didn't just double the size of the inode table. It is dynamically determined based on the data structure. I'm not a file system expert (to call me a novice would probably be stretching it), so I'm hoping someone more versed can chime in. All the code does is query the data structure (specifically, the s_inode_size field of the structure) and use that value instead of blindly assuming an inode size of 128. I don't think it's a matter of what is done with the extra bits, since it's just querying the size of an already created filesystem. Thanks, Josh