From owner-svn-src-all@FreeBSD.ORG Sun May 22 10:41:38 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D7DA106566B; Sun, 22 May 2011 10:41:38 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail4out.barnet.com.au (mail4out.barnet.com.au [202.83.178.123]) by mx1.freebsd.org (Postfix) with ESMTP id 0891C8FC0C; Sun, 22 May 2011 10:41:37 +0000 (UTC) Received: by mail4out.barnet.com.au (Postfix, from userid 1001) id EFB1737BAD7; Sun, 22 May 2011 20:16:49 +1000 (EST) X-Viruscan-Id: <4DD8E291000141025A98A4@BarNet> Received: from mail4auth.barnet.com.au (mail4.barnet.com.au [202.83.178.125]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.barnet.com.au", Issuer "Equifax" (verified OK)) by mail4.barnet.com.au (Postfix) with ESMTPS id 99DBB4222AE; Sun, 22 May 2011 20:16:49 +1000 (EST) Received: from [10.204.250.208] (ppp121-45-190-113.lns6.syd7.internode.on.net [121.45.190.113]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) by mail4auth.barnet.com.au (Postfix) with ESMTPSA id 3F44237B984; Sun, 22 May 2011 20:16:49 +1000 (EST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=iso-8859-1 From: Edwin Groothuis In-Reply-To: <20110522092937.GS31223@acme.spoerlein.net> Date: Sun, 22 May 2011 20:16:47 +1000 Content-Transfer-Encoding: quoted-printable Message-Id: <3AA8EEBF-4C35-41A3-9516-09044CADAD0C@mavetju.org> References: <201105191309.p4JD9dXY038734@svn.freebsd.org> <20110522092937.GS31223@acme.spoerlein.net> To: =?iso-8859-1?Q?Ulrich_Sp=F6rlein?= X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r222094 - head/share/misc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 May 2011 10:41:38 -0000 On 22/05/2011, at 7:29 PM, Ulrich Sp=F6rlein wrote: > On Thu, 19.05.2011 at 13:09:39 +0000, Edwin Groothuis wrote: >> Author: edwin >> Date: Thu May 19 13:09:39 2011 >> New Revision: 222094 >> URL: http://svn.freebsd.org/changeset/base/222094 >>=20 >> Log: >> Put AN back after finding out that tzsetup(1) will complain that >> it doesn't exist. It will be removed again once the tzdata = distribution >> files have been updated with the replacements for AN. >=20 > Wouldn't it be better to have tzsetup use iso3166.tab from the tzdata > distribution, which is mostly guaranteed to be in sync with zone.tab? Which opens a different can of worms. Duplicate file, with semi-similar contents. Whenever there are changes in the distribution of the tzdata iso3166.tab = equivalent file, I check if they are in the /usr/share/misc equivalent = file. A warning to that file should be added that tzsetup uses it and that = they always should check tzsetup functionality before commiting it. Edwin=